Date: Wed, 11 May 2022 22:01:35 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Ian Lawrence Barwick <barwick@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: First draft of the PG 15 release notes
Message-ID: <Ynxqf4PxtbP7UtLH@momjian.us>
References: <YnqIT8kpiO3m6SD7@momjian.us>
 <CAB8KJ=jmLBMAmxjcew12-yntb7m3FH-8A2+Qb7+RybZp1w9GOg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAB8KJ=jmLBMAmxjcew12-yntb7m3FH-8A2+Qb7+RybZp1w9GOg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Ynxqf4PxtbP7UtLH%40momjian.us>
Precedence: bulk

On Thu, May 12, 2022 at 10:37:56AM +0900, Ian Lawrence Barwick wrote:
> >> Remove exclusive backup mode (David Steele, Nathan Bossart)
> >>
> >> If the database server stops abruptly while in this mode, the server could fail to start.
> >> The non-exclusive backup mode requires a continuous database connection during the backup.
> 
> It'd be useful to mention exclusive backup mode has been deprecated since 9.6,
> lest the impression arise that an important-sounding feature has been torn out
> suddenly. Also not sure why we need to mention that non-exclusive backup

Well, the documentation was clear about it being deprecated, so I don't
see a need to mention it in the release notes.

> requires a continuous database connection, AFAIR that was also the case with
> exclusive backups.

Uh, you could do pg_backup_start, disconnect, then pg_backup_stop, no? 
I thought the non-exclusive mode required a continuous connection
because it aborts if you disconnect.

> The patch also removed 4 and added 2 new functions, a change which anyone
> maintaining backup utilities would need to be aware of.
> 
> Patch attached with suggested changes.

Oh, good points, I had not noticed those renames and removals.  URL
updated with new text.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson