Date: Thu, 12 May 2022 14:27:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three -
 remastered set
Message-ID: <YnyawnlheodeuFfS@paquier.xyz>
References: <YkUpwzGHcAKlj81C@paquier.xyz>
 <502623.1648702814@sss.pgh.pa.us>
 <20220331053616.u446wsr732quuzer@alap3.anarazel.de>
 <YkVetIPIk1ScfC9Q@paquier.xyz>
 <547429.1648734590@sss.pgh.pa.us>
 <YkZSgJ8tGy2tAWwf@paquier.xyz>
 <20220502042718.GB1565149@rfd.leadboat.com>
 <YniID7Lm9bZUoQXl@paquier.xyz>
 <YnsRiDW5tY8z0oCf@paquier.xyz>
 <20220511053255.GA2578591@rfd.leadboat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+C84MWjCzRXoD+JB"
Content-Disposition: inline
In-Reply-To: <20220511053255.GA2578591@rfd.leadboat.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YnyawnlheodeuFfS%40paquier.xyz>
Precedence: bulk


--+C84MWjCzRXoD+JB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 10, 2022 at 10:32:55PM -0700, Noah Misch wrote:
> Why did you discontinue testing the longstanding test database name?

I am not sure what you mean here.  Are you saying that the test should
be changed to prefix each database name by "regression", as it was the
case in test.sh?  Or do you mean that the backslash/double-quote
business should only apply to the first database name and not the
other two, implying that the new generate_db() in 002_pg_upgrade.pl
had better have a $prefix and a $suffix like it was originally
written?
--
Michael

--+C84MWjCzRXoD+JB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJ8msIACgkQnvQgOdby
QH0BFQ//R/CQ93GXKmMaDRYk3GqTToX7S0uFZIzvyK25T/YlTXkAvmGgt1OvdBx+
ROj4DrM0WqoRmaBgG4P9MKg3xH3eH89zqkv4YY5csfr83cu+0ulSB393uWknM7Ur
Sm2dif/kO31uw4m9ADCAtXxlnn7DLnpWhQW9v4zeC0n1XN4jfq02CQ9eCY8O2faO
cspeN2/j8qh25OPuwxZVJv/+6WaNO79exIjao98GHMDhNDEkCyaddNts/vj0fxr9
Ssddh5oNDz6SzqczkrBWhaS0qsxEX2LtqdxRnzGluVmZOLLJTwDw330YLXzLy69Q
yowOcthDeY6DlArM1qnMlkJ2InpRyTRVwH5JNDUZZEZqjnIIgVB5rTh6XUr6dWIr
wmoNzq6kW5AfuzqGA2yJHhHgcb88Rk4bt32AfR50mCRHizcXg6r1rHzn9VcwGq7K
xEGfWhFAPCAeh9iLpe5BVTyZnf7T48TNJQ0OPT7NtFDt4kNlTKrxV1+C0zzf6JOM
hpaNTW0phe+blyGh9h6g8S7DGpKWwpvhgKE41it5T29o8gjqID17tE38vWQqs6Ph
xmB5a85LdVgZiKMG1sGOSXpcOsJHbrW+k0i1ebwWBwZDaupfEwMTjfmai+NPU2d3
TkYxMTkUdWqQMwe6w4V/A2tGuhr6GbcZfVLskBUSb19/Pj5ZmCs=
=iDm4
-----END PGP SIGNATURE-----

--+C84MWjCzRXoD+JB--