Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntj8O-0002R6-GL for pgsql-hackers@arkaria.postgresql.org; Wed, 25 May 2022 05:00:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ntj8N-0007yO-4B for pgsql-hackers@arkaria.postgresql.org; Wed, 25 May 2022 05:00:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntj8M-0007yF-6z for pgsql-hackers@lists.postgresql.org; Wed, 25 May 2022 05:00:34 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntj8H-0008CK-OH for pgsql-hackers@postgresql.org; Wed, 25 May 2022 05:00:33 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2FF645C01D6; Wed, 25 May 2022 01:00:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 25 May 2022 01:00:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1653454828; x=1653541228; bh=cDatc9ZR5L e+phMCz5etpR6kRVMoaBSyu/HO9UB9Yf4=; b=bVsHsEL6JeVIVQ8l0Q+92ZKOnh No9UL0OD/o18NLvuw8a7R/7FS2ABHsOF0J6y7srRdHdn00zhzFtXNgHJe2KxllqU Biz/RoM89yYJ8lrs5TcSwD+chQXw9oK4B5YzIZZaE3XorSHhcfR+H1ub32szxMn2 4V/L4PqHvem4TAeRsFUl2jf2je1DRy/3u7pQPTdsKNFWERtAyQRwCDOs8p9P6D6n XUvw+FPYFLYae5Vm8neOCsPmkiqiaX/fVMNWKSvPiS9WasApv9fv2E2ZJdQae28f Ra2hkHJpcgN3SCAt4Y15iJrqAVZ45rx/rh9OJ3KfTITOia0rdCJMfjAA8kUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653454828; x=1653541228; bh=cDatc9ZR5Le+phMCz5etpR6kRVMo aBSyu/HO9UB9Yf4=; b=aJviJ/+uHObJIibd7WJK/17wUWm5/gk1wu2L5yaon0nd sCKOj6TmfzDuhKzveZLweoaZR95Nge0RmJpUOj9oFl8PwW9eJPo6k524JZakSf8X o6L2kIsW7LpPwTjUQ4NOb8P0Er7Hfk1A/nBkaGtGIioBYH2UnGT7vMdsHYvpnL24 VXLsg9h0GhSKRUdnYmeVvRAM8BsYzu1XFPd8KwGceK49qWbqRzLaADR18+fV2DM5 Iy+0iAPVD3NIV+LbwjAJ1IAfWP+HWQjil/qQNbwinb8gyUgdUrhTA6Lb9tLjVmt5 XRYZK3DRy5ka6CeEp+cJOZZthJ6HUJHHrfcXPKxF1w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeeggdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 May 2022 01:00:26 -0400 (EDT) Date: Wed, 25 May 2022 14:00:23 +0900 From: Michael Paquier To: Andres Freund Cc: Kyotaro Horiguchi , nathandbossart@gmail.com, pgsql-hackers@postgresql.org Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample Message-ID: References: <20220524220147.GA1298892@nathanxps13> <20220525.131140.1773417448061343533.horikyota.ntt@gmail.com> <20220525042332.j7ro2y32un4zm2q5@alap3.anarazel.de> <20220525042849.vpgxdcsbcr3uq4ek@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qs3MhNVCwQ+9pgCq" Content-Disposition: inline In-Reply-To: <20220525042849.vpgxdcsbcr3uq4ek@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --qs3MhNVCwQ+9pgCq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 24, 2022 at 09:28:49PM -0700, Andres Freund wrote: > And done. Thanks Nathan! Shouldn't you also refresh pgstat_fetch_consistency in pgstat.c for consistency? > I wonder if we should make src/test/modules/test_misc/t/003_check_guc.pl > detect this kind of thing? That sounds like a good idea to me. -- Michael --qs3MhNVCwQ+9pgCq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKNt+cACgkQnvQgOdby QH0EnA/+P0jVZKEBq48HMofhjG6AUp78Oyq75o+2GAA+TBOJGFdZ993C5sszimij spb4smfG3ixoAjDmU6zMX1hYPJ2BqBAmKIE0DlVBH6hxjRNd7oL76CRdNi/fWBMK 9UKMi9Ivx/gf6pIAFR63lHA1cuInoEtRCasyCqUyT/hU4CPFY3dkpGwKmGh+DyA6 9/jyRlqTOvJvZqrH9WZ1GCdfI9szGoj12xZ1+iIwQzOcQfpgXAEHzyyzHGsbLxPJ 4wLiSH8M9+h2HwmDZhXffJOKPJtBmXxpwG6I4OYDqUsqjWx4A1vtIWryQ67yklI9 SERktgqJU3SU1ClzCJbgV2oxjW8/BZ4QTlAxhWqX39NijB6Rvf98yjvKAWYg0rF6 boL23GgmtVDqddxeSx5xwlt89FhmPYhnDItWXv8hxBpYSc6D7uSAJUntXqH3qcYc v/xpYNUZQbFTiuq8Uy0m7Jm/YsjMpEzleTCyK44OGJMTsaxLqMd02o7OPDJgUlPj lPAlGmTfVSQTiMKAxANXHffmTQ0MwW856s9YGoMNSwWaUYFhCvgrvgYgw6amRSpp 0va/WfFLWF4ilfFR7WX+0wHSyAXRF4KUXnFVq+pxgxm9SjX/o2haTGtrL7AzsSp3 1weEwp6UFON/+PMBJWk0t5hz856VQnBnBK9pZIZmJQF3Zpc20Lk= =2NgS -----END PGP SIGNATURE----- --qs3MhNVCwQ+9pgCq--