Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntiFp-0007qN-IJ for pgsql-hackers@arkaria.postgresql.org; Wed, 25 May 2022 04:04:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ntiFo-0008Du-CH for pgsql-hackers@arkaria.postgresql.org; Wed, 25 May 2022 04:04:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntiFo-0008Dl-2k for pgsql-hackers@lists.postgresql.org; Wed, 25 May 2022 04:04:12 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntiFl-0007eh-CH for pgsql-hackers@postgresql.org; Wed, 25 May 2022 04:04:11 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 48CBD5C0271; Wed, 25 May 2022 00:04:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 25 May 2022 00:04:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1653451448; x=1653537848; bh=/knzaQjTPe T8cEscCJ5SzD6XGYg3JGdR7BIsDBN+zTs=; b=viqVm7tXVQfb8OxX69U5EtQItM AmOPU969b4u0PCvkXeJsCY7GrkzFVhJsEPFEdnSMGDm8ZxOeMmW7KhGLrEavSS8H N91glOQ5JSWNRTh84K7rqPFc+POrxovyBLvvAB54Ykr0WyV91fJAqD4PplVdsALO DPW34My+F2rFv2+Tluh1+QEoPLHkLUCgqja6c8EWrvS+lCAeJnlxUi11jXdmPpMZ hklguQgxzTjj59wXpyZjfX/gQ0z7OFGCLyAPKJ0BQae9lJHOyVKjN8nVjILvkBkJ 3w5NTFpLSKCJpGZ8C4E7FvxQaT8kQf/3bnmQsv1Ro2Rh/JBH2eSGpi8wt6Eg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653451448; x=1653537848; bh=/knzaQjTPeT8cEscCJ5SzD6XGYg3 JGdR7BIsDBN+zTs=; b=WoCfB35uslUvlSEYdCCnOtYfBqdlSin5HzYEyJHHGnnq xh4PQPK3n3paLijofo1X29erp+z65QDUe//Fs/9mhvROFBG0A9cvyXyZVBJvAAC8 wob2pYMRxe2k7rhl+1BYKC4lpZ7aTKc1A7IBR620d6tFVA0v0ZK3Ml80i+R7YYlg ug5xv3f0kaZUE0/n5DTz5kD6gA9qCriM5FJYF0ucWlukD2w1hmmeEbpeu/Av3R2V jEsz+5LZZ5adLFfzPVQsTnG9Go7dbRk9GXjd9Uwew2L0yWzL6FATiNKYGgP8dkun omRUQIM1WfALZqWHB9yqLVlOCnBfGxh3H24Dn37BVw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeeggdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 May 2022 00:04:06 -0400 (EDT) Date: Wed, 25 May 2022 13:04:04 +0900 From: Michael Paquier To: Nathan Bossart Cc: Ian Lawrence Barwick , pgsql-hackers Subject: Re: docs: mention "pg_read_all_stats" in "track_activities" description Message-ID: References: <20220520230837.GB877934@nathanxps13> <20220521185743.GA886636@nathanxps13> <20220522202608.GA892371@nathanxps13> <20220523164142.GB938919@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f6ZN+ZIyfnXF9CC7" Content-Disposition: inline In-Reply-To: <20220523164142.GB938919@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --f6ZN+ZIyfnXF9CC7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 23, 2022 at 09:41:42AM -0700, Nathan Bossart wrote: > I think we need to be careful about saying "member of" when we really mean > "roles with privileges of." Unless I am mistaken, role membership alone is > not sufficient for viewing this information. You also need to inherit the > role's privileges via INHERIT. Good point. So this would give, to be exact: "This information is only visible to superusers, roles with privileges of the pg_read_all_stats role, and and the user owning the sessionS being reported on (including sessions belonging to a role they have the privileges of)." Opinions? -- Michael --f6ZN+ZIyfnXF9CC7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKNqrQACgkQnvQgOdby QH1Hww/+O/Qt3Rm5FhnRuoN1UEeenVw0iPfC/oD1FpmegZMD6FcVnz97yflCyJqU y7g1kFjhE8E5MjQXkKzNjeI7FXajLBe4sokCMzKBrTZ/i3PSR6qWbEmWrToZu5ag m++DmIDFb87WMh0osnKT+D2ny/L1nZP265AqGEBLMkGbocB/6enB7u+iCwcSYKEn UDwQnBd6ctbuHrmbwnZzfklWIzSILXOvhgyg7OHm1bbfo9Z2JUGstd3XgNjLxM3l FueI4JpDtucxcSy0PZS5f4FIGoVlKDwjQDvhl109TsOBaOpgWagbTf4eAWSq6kZ1 rQYUq794WlR6kvZwoazRZ6Fn7nrl/fo5HKEapxseomvB+koCq4TV2W9y5E9dSjaL t1osx7YjeXoc62w2+vS7uHauLmOg4k8go4NZvE2LOV8z1XoNjDbwoVhn44+7kZnQ 8x2UV2o/m0agjnrsqVk+DNFEAMbR/Fw2jooRs3d9x4YTq42XGvuk+xGTYrHwWxSX fQG0UTZ3kgQ+7ui3lYVL4kFkIHC0YOBfwsTR6+OhsjP/xhM+FWx63vCRpvBFaiX7 PxDTdrj+/7MgYhV6SA3PA+wPKbZN2NA7yJewuWERwnfAjEFYd+7GlsMlf8m5UL3F MleMutH6heqPemlYxvRqVUNcvUHoa1rxFFsO6Z4yZel8aZoW4Jw= =5A6v -----END PGP SIGNATURE----- --f6ZN+ZIyfnXF9CC7--