Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntiJl-00082W-HA for pgsql-hackers@arkaria.postgresql.org; Wed, 25 May 2022 04:08:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ntiJk-0007VY-8P for pgsql-hackers@arkaria.postgresql.org; Wed, 25 May 2022 04:08:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntiJj-0007VP-VO for pgsql-hackers@lists.postgresql.org; Wed, 25 May 2022 04:08:15 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntiJh-0003ib-IY for pgsql-hackers@postgresql.org; Wed, 25 May 2022 04:08:14 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B6EBC5C0268; Wed, 25 May 2022 00:08:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 25 May 2022 00:08:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1653451692; x=1653538092; bh=rer4DXodW+ mQryetKrn84JMZoftzJFX5dmmuQd+xUlE=; b=V3cV6rXv3VF2NlkshwK9f0K/S5 JzHRTqakugbHAOFuph110R7Pik3kNurpSxWaa/fomp4lOKmDWOMyWvsqNAp08qSJ W+jSOvOFOzEBntgAPEzN86fYjJL34p4f9vKVkCAZy+Fmv7xl0U01S1y44ylT/A17 TCz9jZbCsBr8EWWrFCqjiIJnW6v7w7qUWXGmrMjlhuvmXFhULsuN43LPD8fEYuyb y9lmaSA6ehzScBf5YP007c7sprYjVI5BosBfmc0rCcPjx6hcILx0iI4QYEOwmkco UhazqXu7SjkVPSu97QkZpV8zeMYqJP2fcGSpxYY7gDyv2C8L1uqLfs6GXDXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653451692; x=1653538092; bh=rer4DXodW+mQryetKrn84JMZoftz JFX5dmmuQd+xUlE=; b=KUnUiThZ6hJOjZapodhRREi92IBqF5v95EpHEH7FdBTU 5V0weI709LOPSlgfanzKr/y/CRadwTpWjOppGpWmmaIxku7LqK0ZZTPiD3ydNfwL EKkcGtaBq/m2AWXWop+f3dCKIDanQyWSsoqVv/Zp9apo0MQ5wofa1NI5Dp/wXRYZ UzM7lLDaBjrbQjnOXaOzFA+cbWFHyD82XbaJ+Y/HQvj5avKVVzXVR5E+eUIIDc8F OK8udmkEsusNP4UMml3nyQxIc9kHHe70BijKgt9WrxBBS7yTuvIOriaGy8kRpGxD +LtJOBJd0F0BNRrl15s7/j+M5iqkhLrmh4WLs2JtGg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeeggdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 May 2022 00:08:11 -0400 (EDT) Date: Wed, 25 May 2022 13:08:08 +0900 From: Michael Paquier To: Nathan Bossart Cc: pgsql-hackers@postgresql.org, Andres Freund Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample Message-ID: References: <20220524220147.GA1298892@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FsZHvM9JVkFTBT5B" Content-Disposition: inline In-Reply-To: <20220524220147.GA1298892@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --FsZHvM9JVkFTBT5B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 24, 2022 at 03:01:47PM -0700, Nathan Bossart wrote: > In postgresql.conf.sample, stats_fetch_consistency is set to "none," but > the default appears to be "cache." Should these be consistent? I've > attached a patch to change the entry in the sample. Yes, postgresql.conf.sample should reflect the default, and that's PGSTAT_FETCH_CONSISTENCY_CACHE in guc.c. Andres, shouldn't pgstat_fetch_consistency be initialized to the same in pgstat.c? -- Michael --FsZHvM9JVkFTBT5B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKNq6gACgkQnvQgOdby QH2oShAAjhO85eZ5z4skrCaPP27ijAm5l4rRWpc8T+qHWpfkBPM8QjgbqNggcaKx 0tTlCQgsQQuX+vJQnxeS1X63nqp99aQopxuqsG1FSy//lJUvwN9lvLMS/9a8oknR ws5E+k2XwRJmK/cg9JFJzsTGvUW850HS7Tsv6Wfry0kUXRNaPoLpAChobq7pQctq HaZI0ONL86Y30kYc3KZC5X1ghrmZMn5QngC9yi7pAJOyli1RKjCaFUqZuvpkoMxs xo+6nxTLNAQ6dr76asaRDDUNUm4LVbZvWcVfNCZDmL0g+kH1NhQ616+DYPtphvrI FUjFlvCeYdaYYVlg51UInEZB98UNYGHHEPDK0d95WzRU3tfcQq4PIXJOlfzTlJmr 9q0JDTFwllLAhxrWEXgCUBN6vti0eJTOg0pDKUbarwFwORsImsshVc/bkLh84PuE yZB5gW0i5lqXF6cl1/LRgifX3MNOorSaTFQ2ygLdPzrX0tQ8f1xGB1xPis76G9Zz O2hMX+C+mCHv6nlmGgJD54yG8JgIKpwc0uiJC6W+/hAiT8JE5hcJb9CKvlw46WyK WCTcpektQ1aCC77md3q8Pp2zQLlWNzy9BeTDpv4xlycs8MYjd4J95VWt0yxdWBYK fDfsJg9eowww/ZzpcXU37nVJX/thx/dcgKxFZk2Oe0NbOMEhvC0= =K4Qp -----END PGP SIGNATURE----- --FsZHvM9JVkFTBT5B--