Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 26 May 2022 08:53:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: andres@anarazel.de, nathandbossart@gmail.com,
	pgsql-hackers@postgresql.org
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Message-ID: <Yo7Bk0tPTyKvIduo@paquier.xyz>
References: <20220525042849.vpgxdcsbcr3uq4ek@alap3.anarazel.de>
 <Yo2351qVYqd/bJws@paquier.xyz>
 <20220525.155623.1140106707572944089.horikyota.ntt@gmail.com>
 <20220525.161207.1389849691748709887.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WoYbkTpfKyH2FMAS"
Content-Disposition: inline
In-Reply-To: <20220525.161207.1389849691748709887.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Yo7Bk0tPTyKvIduo%40paquier.xyz>
Precedence: bulk


--WoYbkTpfKyH2FMAS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 25, 2022 at 04:12:07PM +0900, Kyotaro Horiguchi wrote:
> (sigh..) As the result, no need to fix in this area for now, and I
> don't think there's any generic and reliable way to detect
> inconsistencies of guc variable definitions.

Hmm.  Making the automation test painless in terms of maintenance
consists in making it require zero manual filtering in the list of
GUCs involved, while still being useful in what it can detect.  The
units involved in a GUC make the checks between postgresql.conf.sample=20
and pg_settings.boot_value annoying because they would require extra
calculations depending on the unit with a logic maintained in the
test.

I may be missing something obvious, of course, but it seems to me that
as long as you fetch the values from postgresql.conf.sample and
cross-check them with pg_settings.boot_value for GUCs that do not have
units, the maintenance would be painless, while still being useful (it
would cover the case of enums, for one).  The values need to be
lower-cased for consistency, similarly to the GUC names.
--
Michael

--WoYbkTpfKyH2FMAS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKOwZMACgkQnvQgOdby
QH2j6w//Rdjj3DlPTSTEsiXmwtFPXVerdRRPzBsXP0s38dueXWrmDr/JoUVpEUnL
w5Qw0uQynHY3AXaN5CfXe6Wep1lERJbUoAOdTG5rs6695zpV7VDt6ck6RsiQUJz9
dClBVEIL8sm2jdtUvu3WbOJ5oj9uzDe3XBA0/6SPY1uyaKXPTJHqsuXYI4YEhCbQ
cY0loerRH3+2n/Gz+YOgXtgj/x/FbPrjbG8OHz5BqSOQ4zDsLCTNhOW1bIZHqb53
mFNZlv9vJ251pHFH2yp13cZQc8BFZq3XffVHxc+U7Nw/w32rXbMX2Kp5rzSq/Zf8
qqDapHUxn7zGtEH1B1d3bqQUim5BXZS8Jm/p83JJlHL126ajcCP9+bCKKQQjGsho
kaOfTHyqo8jiBExvcvQZYowHjt4KoDLON7vRmSEdUBSvdIwDaF3qjQRYV0EHaQmM
CqQKO4BDXVOEtb4X7x1J4Y7Tu0JA4DSGdRm9wqXT+BqS3up4nnOUM5AkfE4HQjC7
XDmhAdbA3VCsg3/yxwsIg9o5Pz3uSrBf0nn9ib4mIM4mp5A+e2czF31rZGzs2hoT
ji/u+gfilVs4pSb1JoWH97izCN3p2cIE4n7fntV5Mlf5lxHT1rD5ECAL+bLnyaeg
9LPIHO9LQqaWLxVu1HlkXz7YmCQd2RIgAtMBgRZ0+pS3mPQRsHY=
=lDbe
-----END PGP SIGNATURE-----

--WoYbkTpfKyH2FMAS--