Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 26 May 2022 11:59:40 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha
 <juanjo.santamaria@gmail.com>
Subject: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Message-ID: <Yo7tHKD8VCkeNi71@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="W6S8nCAL2yDDIoE+"
Content-Disposition: inline
Archived-At: 
 <https://www.postgresql.org/message-id/Yo7tHKD8VCkeNi71%40paquier.xyz>
Precedence: bulk


--W6S8nCAL2yDDIoE+
Content-Type: multipart/mixed; boundary="bbmc/nkjDrZ0l1z2"
Content-Disposition: inline


--bbmc/nkjDrZ0l1z2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

On the thread about the removal of VS 2013, Jose (in CC) has mentioned
that bumping MIN_WINNT independently would make sense, as the
simplication of locales would expose under MinGW some code for
GetLocaleInfoEx():
https://www.postgresql.org/message-id/CAC+AXB3himFH+-pGRO1cYju6zF2hLH6VmwPbf5RAytF1UBm_nw@mail.gmail.com

Attached is a patch to set MIN_WINNT, the minimal version of Windows
allowed at run-time to 0x0600 for all environments, aka Vista.  This
results in removing the support for XP at run-time when compiling with
anything else than VS >= 2015 (VS 2013, MinGW, etc.).  We could cut
things more, I hope, but this bump makes sense in itself with the
business related to locales.

What I would like to do is to apply that at the beginning of the dev
cycle for v16, in parallel of the removal of VS 2013.  This move is
rather independent of the other thread, which is why I am spawning a
new one here.  And it is better than having to dig into the other
thread for a change like that.

Thoughts or opinions?
--
Michael

--bbmc/nkjDrZ0l1z2
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-Bump-WIN_MINNT-to-0x0600-everywhere.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 26da923e3007e7eb1b459826158623c9db47e983 Mon Sep 17 00:00:00 2001
=46rom: Michael Paquier <michael@paquier.xyz>
Date: Thu, 26 May 2022 10:20:06 +0900
Subject: [PATCH] Bump WIN_MINNT to 0x0600 everywhere

---
 src/include/port/win32.h          | 10 +++-------
 src/backend/utils/adt/pg_locale.c |  4 ++--
 doc/src/sgml/installation.sgml    |  2 +-
 3 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/include/port/win32.h b/src/include/port/win32.h
index c6213c77c3..4d24c46812 100644
--- a/src/include/port/win32.h
+++ b/src/include/port/win32.h
@@ -11,15 +11,11 @@
=20
 /*
  * Make sure _WIN32_WINNT has the minimum required value.
- * Leave a higher value in place. When building with at least Visual
- * Studio 2015 the minimum requirement is Windows Vista (0x0600) to
- * get support for GetLocaleInfoEx() with locales. For everything else
- * the minimum version is Windows XP (0x0501).
+ * Leave a higher value in place.  The minimum requirement is Windows Vista
+ * (0x0600) to get support for GetLocaleInfoEx() with locales.
  */
-#if defined(_MSC_VER) && _MSC_VER >=3D 1900
+#if defined(_MSC_VER)
 #define MIN_WINNT 0x0600
-#else
-#define MIN_WINNT 0x0501
 #endif
=20
 #if defined(_WIN32_WINNT) && _WIN32_WINNT < MIN_WINNT
diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_l=
ocale.c
index a0490a7522..4c39841b99 100644
--- a/src/backend/utils/adt/pg_locale.c
+++ b/src/backend/utils/adt/pg_locale.c
@@ -1729,7 +1729,7 @@ get_collation_actual_version(char collprovider, const=
 char *collcollate)
 		else
 			ereport(ERROR,
 					(errmsg("could not load locale \"%s\"", collcollate)));
-#elif defined(WIN32) && _WIN32_WINNT >=3D 0x0600
+#elif defined(WIN32)
 		/*
 		 * If we are targeting Windows Vista and above, we can ask for a name
 		 * given a collation name (earlier versions required a location code
@@ -1757,7 +1757,7 @@ get_collation_actual_version(char collprovider, const=
 char *collcollate)
 							collcollate,
 							GetLastError())));
 		}
-		collversion =3D psprintf("%d.%d,%d.%d",
+		collversion =3D psprintf("%ld.%ld,%ld.%ld",
 							   (version.dwNLSVersion >> 8) & 0xFFFF,
 							   version.dwNLSVersion & 0xFF,
 							   (version.dwDefinedVersion >> 8) & 0xFFFF,
diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index c585078029..5e2541137b 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -2136,7 +2136,7 @@ export MANPATH
=20
   <para>
    <productname>PostgreSQL</productname> can be expected to work on these =
operating
-   systems: Linux (all recent distributions), Windows (XP and later),
+   systems: Linux (all recent distributions), Windows (Vista and later),
    FreeBSD, OpenBSD, NetBSD, macOS, AIX, HP/UX, and Solaris.
    Other Unix-like systems may also work but are not currently
    being tested.  In most cases, all CPU architectures supported by
--=20
2.36.1


--bbmc/nkjDrZ0l1z2--

--W6S8nCAL2yDDIoE+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKO7RwACgkQnvQgOdby
QH2MwQ/+LNRdiHrMrAEtYNBpo7yrZ8LgA6V88oq3czTn4HLzvDVWqHrHd0WpD1xr
/UfMCuJYCtmbNMBTqwB/hjMM9PRkBloFYCR6XrG37fDPNXtZlkItlMpFYJgXm6jb
Rg0/EPp9tGs2OMSWP2VQr1lbVa0LPhHSeyg/OmsOyGsXVVOB15n5kSDnBUvezr4e
yFwcYfsZjKbV380BVBb9HjMC1mjmZpjRCUZfGxzFt/b6zQ+oMj5SB2Hzlh0aCYTK
8MLPDTCi5N9qjbPoX5cXpgIk5qEis+QqZExwsOK9b+J59Qy8Ud54rgUYQYcqtox7
dSDjC/yYVEq+/soBITGjB6HVXfJW1BmiV+lpax+8HvX+c+7niYKd10NbT7CT3IX+
35o3cuQgslm6c1jBbwvr5rm3VnCwrINdssM5C3ZPP6Ubv5i+pG2Lylfmeih7iqIc
sVLRnKKggwdOgtNLVPORLjinVISXJg92JRBOEw371TvmTQVMKCFQoneK6iOVE+uU
RnGHNn061oSrKhxnr7rxMXTZ645gD4nP0MhvIA2t8p/qcSdfxGxehHv1WRQ1TGqJ
l+Sgp7QPBOentKe8ztnt7drglUVF9mcF2pz6ikX2F51pN0HjixVeeRbhV6gc0Ey8
cLwSnljtEoGkrYBKqCuWGHBzy2aVfIqsEZBv3pxB8S74FIUx7FU=
=yZN3
-----END PGP SIGNATURE-----

--W6S8nCAL2yDDIoE+--