Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 23 May 2022 08:53:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: docs: mention "pg_read_all_stats" in "track_activities"
 description
Message-ID: <YorM9Kv4bFVBoCsI@paquier.xyz>
References: 
 <CAB8KJ=jhPyYFu-A5r-ZGP+Ax715mUKsMxAGcEQ9Cx_mBAmrPow@mail.gmail.com>
 <20220520230837.GB877934@nathanxps13>
 <YohcelRv74nuHC9Z@paquier.xyz>
 <20220521185743.GA886636@nathanxps13>
 <YomLAynQiordq3lg@paquier.xyz>
 <20220522202608.GA892371@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Wc7bo7qgprD1Vfn9"
Content-Disposition: inline
In-Reply-To: <20220522202608.GA892371@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/YorM9Kv4bFVBoCsI%40paquier.xyz>
Precedence: bulk


--Wc7bo7qgprD1Vfn9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, May 22, 2022 at 01:26:08PM -0700, Nathan Bossart wrote:
> Yeah, this crossed my mind.  I thought that "superusers, roles with
> privileges of the pg_read_all_stats_role, roles with privileges of the us=
er
> owning the session being reported on, and the user owning the session bei=
ng
> reported on" might be too long-winded and redundant.  But I see your point
> that it might be a bit confusing.  Perhaps it could be trimmed down to
> something like this:
>=20
> 	... superusers, roles with privileges of the pg_read_all_stats role,
> 	and roles with privileges of the user owning the session being reported
> 	on (including the session owner).

Yeah, that sounds better to me.  monitoring.sgml has a different way
of wording what looks like the same thing for pg_stat_xact_*_tables:
"Ordinary users can only see all the information about their own
sessions (sessions belonging to a role that they are a member of)".

So you could say instead something like: this information is only
visible to superusers, roles with privileges of the pg_read_all_stats
role, and the user owning the sessionS being reported on (including
sessions belonging to a role that they are a member of).
--
Michael

--Wc7bo7qgprD1Vfn9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKKzPQACgkQnvQgOdby
QH36Xg/+JAqalAfMMitlZIqR2kLxiRwVEIzX6F8lC8Lw9jVDj8ge4V+amMUbGQ4f
LKw7+CjKWk7AHV8GIUZVj4DGfVAU91iy83jq+F+5XtHBPmYXo2+EkS9fCDOcMp3O
QnuCL82Y6l58TbVWwEsNZPzw67U0fYeLroGjbcK775xPNzdF5dLkaV9263ESMp9F
l8yT10nD12kUWUYwVPMiZBodWnI3ycwiiWuOUtvxBQz9cLLZsIQpj/ffpNAhwFL9
EaUOiYjUU8L7xgoiEW/XpAYLIa3AskYiIJRjegGUPvZjIoyNREchxlFOZv0W0HVn
Ab3W3rLDjwcvEjBtdHb8bp5zefSUPBrYCVrf3N9W8Z2g8WBYKUbzgzPsoJm5dHB1
dkoKofucpWjUQgUnpzQlw3xAHxYqEgmwSRFzASnpGoZ5C7uQlEIyoeCFce0kBkUp
1xMTPte48q4lq0QILPCSGI5XdsbgpfpxGFU+Fx6Hfk09nzZOl+nbMuPEjkpEdDva
I6DzEs3bpjnjeq9HAYe3jZc54TikuOZHxKzR6zcYcEsTgrUrvJhyOM7EhSswjSm7
neILAN8c8BAoQpzVBP/coYSDc1jEQuRxpQJF3kxBt7s7t8pqzJBHqUtFjnfdwiad
OSVbAPODe9IS0fH/eS8EzxbTuBsnc1UmUKkQhR3jdfPNbNvog7Q=
=WWp1
-----END PGP SIGNATURE-----

--Wc7bo7qgprD1Vfn9--