Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 31 May 2022 13:58:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Andrew Dunstan <andrew@dunslane.net>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	pgsql-hackers@postgresql.org
Subject: Re: convert libpq uri-regress tests to tap test
Message-ID: <YpWgcbXZD4FAdz5a@paquier.xyz>
References: <4f4c04c2-f23c-6668-1b24-224fc6478bfd@enterprisedb.com>
 <1276236.1645667561@sss.pgh.pa.us>
 <f51d3f80-3b9d-7ba4-fbd7-06ce63ea15f1@enterprisedb.com>
 <20220224144311.4rcax7tslk7jum3f@alap3.anarazel.de>
 <1346756.1645715848@sss.pgh.pa.us>
 <20220224164623.m3vdtr7ojilhaxgz@alap3.anarazel.de>
 <20220225175647.bvordgiauekrbkyj@alap3.anarazel.de>
 <20220226015229.c4ofvhbsd3ej6weo@alap3.anarazel.de>
 <20220227014626.vi7g7km554gmoape@alap3.anarazel.de>
 <20220529151850.GN19626@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="6Hire3K7Kmi15snF"
Content-Disposition: inline
In-Reply-To: <20220529151850.GN19626@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YpWgcbXZD4FAdz5a%40paquier.xyz>
Precedence: bulk


--6Hire3K7Kmi15snF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, May 29, 2022 at 10:18:50AM -0500, Justin Pryzby wrote:
> On Sat, Feb 26, 2022 at 05:46:26PM -0800, Andres Freund wrote:
> > On 2022-02-25 17:52:29 -0800, Andres Freund wrote:
> > > I'd like to commit 0001 and 0002 soon, unless somebody sees a reason =
not to?
> >=20
> > Pushed.
>=20
> If I'm not wrong, this isn't being run by check-world.

You are right.

> -$(call recurse,check-world,src/test src/pl src/interfaces/ecpg contrib s=
rc/bin,check)
> -$(call recurse,checkprep,  src/test src/pl src/interfaces/ecpg contrib s=
rc/bin)
> +$(call recurse,check-world,src/test src/pl src/interfaces/ecpg src/inter=
faces/libpq contrib src/bin,check)
> +$(call recurse,checkprep,  src/test src/pl src/interfaces/ecpg src/inter=
faces/libpq contrib src/bin)
> =20
> -$(call recurse,installcheck-world,src/test src/pl src/interfaces/ecpg co=
ntrib src/bin,installcheck)
> +$(call recurse,installcheck-world,src/test src/pl src/interfaces/ecpg sr=
c/interfaces/libpq contrib src/bin,installcheck)
>  $(call recurse,install-tests,src/test/regress,install-tests)

Why don't you just use src/interfaces/ instead of adding a direct
path to libpq?
--
Michael

--6Hire3K7Kmi15snF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKVoHEACgkQnvQgOdby
QH2Hnw/+JHOIxheeyNbMFminfhwx/OYXISMtgAfCmfa99eg4SegWpxdkoGxfo9lZ
BeYkkKIrVBWEd57gWSHU05tY17XxRkEoop4MF6nfr1V4nU+lfHn99O5Od6I09ZZf
ALQW7NL7AsoXSjQoNJ8SI1QEP5f3d+vIY0fyXrEZHtAcTMk/GOeWDWIL6bVrs91I
VE97rxqsd/5HSXhpa9vjsyB0o2UPMu5rzrWeLnF9rY99GozowHFSqnKrfd8uGC+9
EEJvNy16EX3+5NMBT/sTdz2nfHPSSMEpi077sWKnpsgLSk5JnihZuWUKqDaOgu9y
mt/JBGk3y69oqa1dg40ao1O0/icAGec3GiFv17Ewq6P8cWz42F3SM1kB7QIzi/mJ
uUOPq3VCjo0E9Hyc3IzJtc7GYd9ftGvJrC8w6ABlAzenWBu0tEZ/3z/9wwYR+aTf
YmaINQ8pO6eZkG1Sdahn0juxR7+2nRTiUgyOLxJJ0R5LRmIlMdro6zMJMgDjnbE3
HUulCybquU6x/HRI4wLS31J5yR9YgJUFi6tBCGChtQvmr4S6UM8qGEfCEXVfEIeA
dvm+Jm7wnM8Mpo1W3OuP+Os817Ia38wFY3XGTnvk77gzGmxX7g58hr0EPL2/qWjy
der8B39jCUafTTaziJ0LJy4tVrlMxfF16ZKtSmhGK2c1iuSdvLE=
=rHzt
-----END PGP SIGNATURE-----

--6Hire3K7Kmi15snF--