Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 1 Jun 2022 13:59:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Andrew Dunstan <andrew@dunslane.net>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	pgsql-hackers@postgresql.org
Subject: Re: convert libpq uri-regress tests to tap test
Message-ID: <YpbyGroetlnVYjdT@paquier.xyz>
References: <1276236.1645667561@sss.pgh.pa.us>
 <f51d3f80-3b9d-7ba4-fbd7-06ce63ea15f1@enterprisedb.com>
 <20220224144311.4rcax7tslk7jum3f@alap3.anarazel.de>
 <1346756.1645715848@sss.pgh.pa.us>
 <20220224164623.m3vdtr7ojilhaxgz@alap3.anarazel.de>
 <20220225175647.bvordgiauekrbkyj@alap3.anarazel.de>
 <20220226015229.c4ofvhbsd3ej6weo@alap3.anarazel.de>
 <20220227014626.vi7g7km554gmoape@alap3.anarazel.de>
 <20220529151850.GN19626@telsasoft.com>
 <YpWgcbXZD4FAdz5a@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FCVBx2uXePK17VDz"
Content-Disposition: inline
In-Reply-To: <YpWgcbXZD4FAdz5a@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/YpbyGroetlnVYjdT%40paquier.xyz>
Precedence: bulk


--FCVBx2uXePK17VDz
Content-Type: multipart/mixed; boundary="HdjY0NqM9i5yWNKs"
Content-Disposition: inline


--HdjY0NqM9i5yWNKs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 31, 2022 at 01:58:25PM +0900, Michael Paquier wrote:
> Why don't you just use src/interfaces/ instead of adding a direct
> path to libpq?

So, this leads to something like the attached.  Does that sound fine
to you?
--
Michael

--HdjY0NqM9i5yWNKs
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v2-0001-libpq-tests-were-not-being-run.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 893ef90ce07084c4e4837205a805c590798ac115 Mon Sep 17 00:00:00 2001
=46rom: Michael Paquier <michael@paquier.xyz>
Date: Wed, 1 Jun 2022 13:57:46 +0900
Subject: [PATCH v2] libpq tests were not being run

---
 GNUmakefile.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/GNUmakefile.in b/GNUmakefile.in
index 2352fc1171..38713b5d12 100644
--- a/GNUmakefile.in
+++ b/GNUmakefile.in
@@ -68,10 +68,10 @@ check check-tests installcheck installcheck-parallel in=
stallcheck-tests: CHECKPR
 check check-tests installcheck installcheck-parallel installcheck-tests: s=
ubmake-generated-headers
 	$(MAKE) -C src/test/regress $@
=20
-$(call recurse,check-world,src/test src/pl src/interfaces/ecpg contrib src=
/bin,check)
-$(call recurse,checkprep,  src/test src/pl src/interfaces/ecpg contrib src=
/bin)
+$(call recurse,check-world,src/test src/pl src/interfaces contrib src/bin,=
check)
+$(call recurse,checkprep,  src/test src/pl src/interfaces contrib src/bin)
=20
-$(call recurse,installcheck-world,src/test src/pl src/interfaces/ecpg cont=
rib src/bin,installcheck)
+$(call recurse,installcheck-world,src/test src/pl src/interfaces contrib s=
rc/bin,installcheck)
 $(call recurse,install-tests,src/test/regress,install-tests)
=20
 GNUmakefile: GNUmakefile.in $(top_builddir)/config.status
--=20
2.36.1


--HdjY0NqM9i5yWNKs--

--FCVBx2uXePK17VDz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKW8hoACgkQnvQgOdby
QH02mg//W/epLVH/+6mQs9CtasheVsM52HFFaGD98FnU1RcLEdrqwOm26BCcByNG
JWqIsPC0n4Xhy6vnQaua41HOlEhZbOvsrOBVEyL10ZxCMEcI/7NFVA6o03CIDgoj
cnRlo46VRIzTkTYPDi0LIUilWlOykUgMOjByB91JPTpd2hiw2T5ppuN4rQQ0Plzi
YahkSay8Cteg+Rfmz4BBQXXm1S20qsRSqGBn8jZ+SsDzACBCSFfacEwx9PDGx7rd
CvUNXTZ8YQkFaDtw0akb5tA+OZkl/t3AU3Tsyt+D5ZPuimUigAbH5Ootjm9WwhSH
re4z1v/fDpb3IfZ6eqWvAyEeWr9u9qQH7G+NELYS0V/uJ1PxwtAM8Ito36IIRIw5
AvXH30VQnIk4TWUN8furnq5ZYsMSP7DGuvm6kV/MdTE2bHTcPiZ3CFrarE8OXVgD
wEUMF6C9mt7c5ubKRo4sEYl+jDd18nc+ioGFe6rLCvD4NFqBlHvGUzbxW92c5QXS
/1ImGUJ9dViHPs3HCWjuAgOorD1aR/YBffVOz4JvwcjpZ5kOMPBuUHFl/E/Xc0ph
ERVOng4bJwffRjj/TuMYx6+aQo5rgRCEvbWBvG28LjtOgvjhc4v4Ro95XKhKivER
lhPye9ZrepbAdvIDZXYwZxuuaZvt4fAREf+PrRkREJdemk4pUGg=
=RckV
-----END PGP SIGNATURE-----

--FCVBx2uXePK17VDz--