Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 2 Jun 2022 09:37:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>,
	pgsql-hackers@postgresql.org
Subject: Re: pg_upgrade test writes to source directory
Message-ID: <YpgGZpoBr59O2yvu@paquier.xyz>
References: <Yo/5MlXbwY4UhMnm@paquier.xyz>
 <2464542.1653603596@sss.pgh.pa.us>
 <YpAMBqPrusng47e0@paquier.xyz>
 <2480063.1653609068@sss.pgh.pa.us>
 <YpAV1y8CUXGGkPJQ@paquier.xyz>
 <20220528195949.tte5fukfr2z6xhrr@alap3.anarazel.de>
 <3131727.1653768841@sss.pgh.pa.us>
 <YpXA7XHZtunxalTr@paquier.xyz>
 <e65a862a-24aa-7482-6d98-49fbb048f22f@enterprisedb.com>
 <20220601211112.td2ato4wjqf7afnv@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gMaJC2LIPZ3S3k1R"
Content-Disposition: inline
In-Reply-To: <20220601211112.td2ato4wjqf7afnv@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YpgGZpoBr59O2yvu%40paquier.xyz>
Precedence: bulk


--gMaJC2LIPZ3S3k1R
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 01, 2022 at 02:11:12PM -0700, Andres Freund wrote:
> Until recently TESTDIR needed to point to the build directory containing the
> binaries. But I'd like to be able to separate test log output from the build
> tree, so that it's easier to capture files generated by tests for CI /
> buildfarm. The goal is to have a separate directory for each test, so we can
> present logs for failed tests separately. That was impossible with TESTDIR,
> because it needed to point to the build directory.

FWIW, this argument sounds sensible to me since I looked at 0001, not
only for the log files, but also to help in the capture of files
generated by the tests like 010_tab_completion.pl.

I don't know yet what to do about this part, so for now I have fixed
the other issue reported by Peter where the test names were missing.
--
Michael

--gMaJC2LIPZ3S3k1R
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKYBmYACgkQnvQgOdby
QH3N6Q//Wu9LP8U0cl7l/7CdFoNTiLNq/YviMBcL9PESl/64Ot8d5LCt9OWu5hQr
rKohLCbnrKnJDmw5D4ifDj+ivF5lJDuPgk8Fk9Q7Mvev+wMivqpJ1PN+4eMkXcil
YSmCV043mLN0epCk3SfT8Y41Jxhl3KlP0+VM8lL6ZT3hx9e0/H9AwcX0R4eQxYWs
wqa9Bd+l9oYpxixNSXDZCNg6Smgb+w+jmapKmcxJuLS+bcB1RrtoQHvGk3PN1/9C
a/lD1hUY4AiaEQBMeVw+1ODB3W9TybWLSiDeSObTSSUhu2XfoWv3Pr1K4/jdVDAn
NU30ByqtIU7q6G2GJZD9/Qc/3RxCfArKit5IHowvr1Jq/ecXfVWNSmFwd6WmWbA5
GEwChnLP2qV5mC5XcpM8s33ZJBtmrE8Ug//Pg2MGNrMj9YnorQ9q7AbjYHLNvqXS
aPqLbPAxF3Cf+nRcJsJgZGpJZVhFYsYWLnpDAYTKjVm8oj8dDeVIGZUDUFwVwEO6
9T6Az2PcW2GBBczBgiJmXBmsLwVOZJO/imcAo/I5hAGX5YTffgwa1TdMZMP+YGIT
4htL3BrUZq8Zp6eRlRctn0XIlQUcVD6uKBWyRHpc19Y6L6wiIagfA7JGkZrs8qfY
uOshdjFMvbMz9d3RFiIDdjfnZ8xqUEwQfPg/d28AtQw7zUWmHSQ=
=7EMT
-----END PGP SIGNATURE-----

--gMaJC2LIPZ3S3k1R--