Date: Sat, 4 Jun 2022 11:21:53 +0200
From: Sandro Santilli <strk@kbt.io>
Sender: strk@kbt.io
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Regina Obe <lr@pcorp.us>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
Message-ID: <YpskMclOjra+0Jzn@c19>
Mail-Followup-To: Sandro Santilli <strk@kbt.io>,
	Daniel Gustafsson <daniel@yesql.se>,
	Laurenz Albe <laurenz.albe@cybertec.at>, Regina Obe <lr@pcorp.us>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <YgakFklJyM5pNdt+@c19>
 <001d01d87211$edbd5b50$c93811f0$@pcorp.us>
 <d3924670ba8fefa42f4bd462c5b7f6349d63f4d3.camel@cybertec.at>
 <6181DA3F-B24A-4313-A0C2-F05D690AA726@yesql.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6181DA3F-B24A-4313-A0C2-F05D690AA726@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/YpskMclOjra%2B0Jzn%40c19>
Precedence: bulk

On Sat, May 28, 2022 at 05:26:05PM +0200, Daniel Gustafsson wrote:
> > On 28 May 2022, at 16:50, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> 
> > I don't think this idea is fundamentally wrong, but I have two worries:
> > 
> > 1. It would be a good idea good to make sure that there is not both
> > "extension--%--2.0.sql" and "extension--1.0--2.0.sql" present.
> > Otherwise the behavior might be indeterministic.
> > 
> > 2. What if you have a "postgis--%--3.3.sql", and somebody tries to upgrade
> > their PostGIS 1.1 installation with it? Would that work?
> > Having a lower bound for a matching version might be a good idea,
> > although I have no idea how to do that.
> 
> Following that reasoning, couldn't a rogue actor inject a fake file (perhaps
> bundled with another innocent looking extension) which takes precedence in
> wildcard matching?

I think whoever can write into the PostgreSQL extension folder will
be able to inject anything anyway....

--strk;