Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 16 Jun 2022 12:14:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Maciek Sakrejda <m.sakrejda@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Robert Haas <robertmhaas@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: warn if GUC set to an invalid shared library
Message-ID: <YqqgJvYwkWLSBXeL@paquier.xyz>
References: 
 <CAOtHd0BTNd_VK9cWOvtbArgPS26+bzTVqSedU7uxUSGrXT_hqA@mail.gmail.com>
 <CAKFQuwaRUiA2UOA7QvRaOnaWD1sbv3h3xB+W9KGSDkcsTpG3oA@mail.gmail.com>
 <164378196169.19783.12147751717180735532.pgcf@coridan.postgresql.org>
 <CA+TgmoYHTu=Qb+OW3v4qR4KRY=Fc0KDvA0FwXuQ8iKrcXHUpbg@mail.gmail.com>
 <20220210015854.GV31460@telsasoft.com>
 <CAOtHd0CQxJCAF77T+0buj57p5EycwzELfyAWMhJ8oZ3nzCZ6fw@mail.gmail.com>
 <2779118.1648062143@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="O0bRbF26aQN6OtT6"
Content-Disposition: inline
In-Reply-To: <2779118.1648062143@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/YqqgJvYwkWLSBXeL%40paquier.xyz>
Precedence: bulk


--O0bRbF26aQN6OtT6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 23, 2022 at 03:02:23PM -0400, Tom Lane wrote:
> I agree with Maciek's concerns about these HINTs being emitted
> inappropriately, but I also have a stylistic gripe: they're only
> halfway hints.  Given that we fix things so they only print when they
> should, the complaint about the server not starting is not a hint,
> it's a fact, which per style guidelines means it should be errdetail.
> So I think this ought to look more like
>=20
> WARNING:  could not access file "xyz"
> DETAIL:  The server will fail to start with this setting.
> HINT:  If the server is shut down, it will be necessary to manually edit =
the
> postgresql.auto.conf file to allow it to start again.
>=20
> I adjusted the wording a bit too --- YMMV, but I think my text is clearer.

It seems to me that there is no objection to the proposed patch, but
an update is required.  Justin?
--
Michael

--O0bRbF26aQN6OtT6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKqoCYACgkQnvQgOdby
QH0O6w//YTQLNzgrlbOwsMUqT/neH5hlorDuXsRiXUP3ypCXTpHYI2KRBkDzIKrQ
au1VBgG0ilxI55XlmeceZkWB8zzJIiUm/PBAJuA4NXvJ+HuOiqJN+OutLY37VAq9
gXHuWYOCexkJFYRse4ymMcsvcJpe0GsaQtwyIpeNqOXR/zlIjanhwzrImmQUxm7H
9fol02h9sIFbrL4A8CqipawtJV2BvYXVdcho1icvLLMg2bQDoePAn3u7Xynevo/Q
4j2McgPNmiegPhtpBRLFGU3W2fYhmgZePI+laUNNxJ3PULEGkzFS/1GwyRRIukfV
B6kVsKhgYsVevmtaxmynEj9kVX4EvgxQt6cygnlF9YjpIQVyxyn2nTfiWi91nxK9
VjlMtA0EBvMHOfTEPfsF6ye7iZA98NglbfVvHa+/RY4vPZwyuLqdi8PQ/ZpS5XBC
wQWsqhI3W8mIlDCmDR2ZdzWAXcAtQ0kq+69I4li/FlG0b6EqEnFdG7mxPDbNCnN4
jG+KiQxthmrhvXJ0N1tHQXUklsVHY/Weyu1loZE4EXL1qCQ/4eX20dZoIbZUxFW7
FdsCLSxqer81DX8ogDkpfZxVVu13GwwdMCVRFM4wB2KKhX1tU6qptXNfgtCsrEF8
ITOKJIpixA7a2fXvztf9pAwdsJi9+odJ3VP5oOJpuFCLQdUB/yc=
=XG0T
-----END PGP SIGNATURE-----

--O0bRbF26aQN6OtT6--