Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 29 Jun 2022 09:17:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= <ilmari@ilmari.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Logging query parmeters in auto_explain
Message-ID: <YruaLdkyEgu6L5ML@paquier.xyz>
References: <87ee09mohb.fsf@wibble.ilmari.org>
 <Yp8D4kb2qZnhNAWJ@paquier.xyz>
 <8735ggn2lf.fsf@wibble.ilmari.org>
 <YqFQbYkFLF4fXuZX@paquier.xyz>
 <87tu8tla5s.fsf@wibble.ilmari.org>
 <Yqg9tlxk0Ghwd7Of@paquier.xyz>
 <87iloml5a5.fsf@wibble.ilmari.org>
 <87fsjql51e.fsf@wibble.ilmari.org>
 <YrqzsLM96tEbFxeU@paquier.xyz>
 <87a69xkv7x.fsf@wibble.ilmari.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="F5sjPC2tU7l/UFyy"
Content-Disposition: inline
In-Reply-To: <87a69xkv7x.fsf@wibble.ilmari.org>
Archived-At: 
 <https://www.postgresql.org/message-id/YruaLdkyEgu6L5ML%40paquier.xyz>
Precedence: bulk


--F5sjPC2tU7l/UFyy
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 28, 2022 at 10:12:18AM +0100, Dagfinn Ilmari Manns=E5ker wrote:
> That makes sense, but I still think the query_log() function definition
> should go at the end (after done_testing()), so the machinery doesn't
> distract from what's actually being tested.

The majority of TAP scripts have their subroutines at the beginning of
the script, and there are few having that at the end.  I won't fight
you on that, but the former is more consistent.

> Also, the second paragraph of the second commit message now belongs in
> the first commit (without the word "Also").

Yep, will fix.  I usually rewrite commit messages before merging them.
--
Michael

--F5sjPC2tU7l/UFyy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmK7mi0ACgkQnvQgOdby
QH12ZA//d1q0tEn91LwCXRs+YTHa/CtiU70OwFpg6H7lOsLuMu972mdzVhnemDRk
haKdyOm3NTvWESJHmJNABjrsZDZc/7YnkosfD+Kc+vEQ9f6LpSs8cndOVlvafDfd
EnM7uC+LTdVNJwkKcSU+KEa40ZNtN7U65qQ3S8AvnjTcw6BaRPcWwpskeode0PLy
ZstdMFL9vtoEgFF1vz3yDKMjqbsqMzuKwP1ckpkiitbXpYp9IVDJJvEuHORPTmpR
SL26d1PE0eBsuJpi48mtEMG+5LpJP79bPC9U/CDs9ylblFUsjhOwwIWFWrLfXWIL
bCm7ABB4Z/6Y02mApmKeWPgXoF9bs3u/kJ0YMd+92Coi8h4TAW4mqVgJ7v8zMSL6
rux6GkXiXC1m/VUFz4g6pg7vN2UB1+wcjaNFEiu28NdAkGamSu7o67gp4lErKFZt
gNuGBLE9MN0a4IEIjWaJ4VA8RIu9WSn9oRbmQF4CpkEeNohBDgYsm+fu/wvrTA1i
uubpq19gRRfVtsoXPSRKqDGPlurtMDxkZuV128oiQLmz641k0B88PISbhpdI3R3E
hXK+FVU16mMSuLcHHg8Fmt606ZeCvtxfLMKbZv2H6yM8+NB+4UY6dSQyppbTUNx2
wduIAfMzz+6C+xhKR/aftB1d/yvuFVbJR6Ir1/UrUr0xh2cvGBQ=
=8eqz
-----END PGP SIGNATURE-----

--F5sjPC2tU7l/UFyy--