Date: Mon, 4 Jul 2022 15:49:52 -0500
From: Jaime Casanova <jcasanov@systemguards.com.ec>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Roberto Mello <roberto.mello@gmail.com>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
	Justin Pryzby <pryzby@telsasoft.com>
Subject: Re: doc: BRIN indexes and autosummarize
Message-ID: <YsNScLPHKcBBp4oO@ahch-to>
References: <20220704152011.4rypgtgfu66rktkq@alvherre.pgsql>
 <20220704193842.b3etivkx3vxqbpwm@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220704193842.b3etivkx3vxqbpwm@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/YsNScLPHKcBBp4oO%40ahch-to>
Precedence: bulk

On Mon, Jul 04, 2022 at 09:38:42PM +0200, Alvaro Herrera wrote:
> What about this?
> 
> -- 
> Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
> "Java is clearly an example of money oriented programming"  (A. Stepanov)

> diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml
> index caf1ea4cef..0a715d41c7 100644
> --- a/doc/src/sgml/brin.sgml
> +++ b/doc/src/sgml/brin.sgml
> @@ -73,31 +73,55 @@
>     summarized range, that range does not automatically acquire a summary
>     tuple; those tuples remain unsummarized until a summarization run is
>     invoked later, creating initial summaries.
> -   This process can be invoked manually using the
> -   <function>brin_summarize_range(regclass, bigint)</function> or
> -   <function>brin_summarize_new_values(regclass)</function> functions;
> -   automatically when <command>VACUUM</command> processes the table;
> -   or by automatic summarization executed by autovacuum, as insertions
> -   occur.  (This last trigger is disabled by default and can be enabled
> -   with the <literal>autosummarize</literal> parameter.)
> -   Conversely, a range can be de-summarized using the
> -   <function>brin_desummarize_range(regclass, bigint)</function> function,
> -   which is useful when the index tuple is no longer a very good
> -   representation because the existing values have changed.
> +  </para>
> +

I feel that somewhere in this paragraph it should be mentioned that is
off by default.

otherwise, +1

-- 
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL