Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 5 Jul 2022 10:19:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, tgl@sss.pgh.pa.us,
	robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: avoid multiple hard links to same WAL file after a crash
Message-ID: <YsORtfT4+fXj/i1V@paquier.xyz>
References: 
 <CA+TgmobGi7b-5fjAWgEO0ebn516n0OyOi-j7+Hyz_j9sAG17og@mail.gmail.com>
 <289699.1649694527@sss.pgh.pa.us>
 <20220411165257.GB1915258@nathanxps13>
 <20220412.154631.417529439388886590.horikyota.ntt@gmail.com>
 <20220412162742.GB2062175@nathanxps13>
 <Ym6GZbqQdlalSKSG@paquier.xyz>
 <Ym+28lDf5sCJ6pAj@paquier.xyz>
 <20220502173907.GB3351307@nathanxps13>
 <20220502230613.GA3398932@nathanxps13>
 <YnOwioN/mo6k1Dtb@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="aJRhL/IitTvIVRST"
Content-Disposition: inline
In-Reply-To: <YnOwioN/mo6k1Dtb@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/YsORtfT4%2BfXj/i1V%40paquier.xyz>
Precedence: bulk


--aJRhL/IitTvIVRST
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 05, 2022 at 08:10:02PM +0900, Michael Paquier wrote:
> I'd agree with removing all the callers at the end.  pgrename() is
> quite robust on Windows, but I'd keep the two checks in
> writeTimeLineHistory(), as the logic around findNewestTimeLine() would
> consider a past TLI history file as in-use even if we have a crash
> just after the file got created in the same path by the same standby,
> and the WAL segment init part.  Your patch does that.

As v16 is now open for business, I have revisited this change and
applied 0001 to change all the callers (aka removal of the assertion
for the WAL receiver when it overwrites a TLI history file).  The
commit log includes details about the reasoning of all the areas
changed, for clarity, as of the WAL recycling part, the TLI history
file part and basic_archive.=20
--
Michael

--aJRhL/IitTvIVRST
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmLDkbUACgkQnvQgOdby
QH3Aig//cnJh97NNnondEn9yfqZ9qwaJeoTFpgg7942TKETXnEsfeOOmBaZjIe2U
UyKHenog9Mcejh4E6qapCtRt4q31a6MhyzqEhQ43ylXOzrDJIXC8ty+mwg3ttlZN
LidrcwGG6tA8xOCzXotuHAi5yZE/Y8DDNr98CTn4PESQwVMU2Ga/XWmalt+ixaK5
RwqJzaJQd4ywQCgmoXmIwe1NIGcQN2/f6OreDUmS6CpkF2q/OWshA9aRrY2P+8y5
vwoHmcdEUPJhcSBwLG9uuktsHSI5OZcZqE+ztFsDKkUL2acKQRt37e5Qo0CtYhHW
yIlvofyUevDYMIcSdhVgjnG3CagBFOl7HcAh8QHM1cmTU6OytC/VfwRFhrv2MSnY
ItcSfP4RkyM0/mZNTYDoMiA750d90FPa8m86SV+q/bQl2QWQKMBJTEUlv+aeI8C2
OessH5c0h4UGBqMuYdTG7vo4e3kkdTwvgTlIcqPjSPUcK/mby03e62ZWmtoQOBzI
Ag9UzXSedLj9Q+ZDAm0t2cbwW18uCEZUc3fmGcJloiUMdV3QL0+JHSbDBppYNHAT
caSXt/cXKH9gNgeJ7VQsiLWSAFXkictWJTp6eWQXCI32AQM6V4feVSNT9Xw4vZAY
VbNK6w6r1Scf6+rhz3Tomq2kkFGllRUCMNQzuUZZHl58kXihQcU=
=nGOO
-----END PGP SIGNATURE-----

--aJRhL/IitTvIVRST--