Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8sQH-0000cA-2j for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Jul 2022 23:57:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o8sQE-00046o-UO for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Jul 2022 23:57:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8sQE-00046f-Kv for pgsql-hackers@lists.postgresql.org; Tue, 05 Jul 2022 23:57:38 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8sQC-0000EZ-DD for pgsql-hackers@postgresql.org; Tue, 05 Jul 2022 23:57:38 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9447D5C00B5; Tue, 5 Jul 2022 19:57:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 05 Jul 2022 19:57:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657065454; x=1657151854; bh=cuNN4Hbo9I iDckXgNhE5+Bl6B5+1siq51mf0lGdXJro=; b=GxHLv3dZ83bG1vkl8MJXLvUQHf Q6SiqsR+yNXTajwW/1r6LskShRt2P1gltgz53efnDiHI/TQBgEECR8MHm8+faoTw D23zp3aIQC6e/R2CPs5APCHYKRFF28cNIGiRM/qCvk08DJbRDG1Z3Bkg+g28O+sh CRcFfuzY9XfWpakwAePiZ9U4SjRordlHA/GKPKEIeQywUHTVVlgP3JinM/ZN8Cux Bpy4XfPnE0jW0hLVU2/CAGxNuVurSNJsQeQLd5BF5hKSoL8UsdB4FefRDL/fPlH3 XM4EhrJUTL6cb+JBeqEGnH0AzX2WzkKNoPqj7gyESDtYmxtHIIU+0R1SzBCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1657065454; x=1657151854; bh=cuNN4Hbo9IiDckXgNhE5+Bl6B5+1 siq51mf0lGdXJro=; b=VwHUI52o5CTfces5lsi1/FX1rCmp55BWMlFmh6W9lGoE XHw5PVHYUQEwtIIlkcJ3G7WhKK8rQIxJM48hsECqRkpcGuLGLH3G/RAtW7BaLyOz EChF4hxAluX2F5wDW7pg3Bnf7PVgfHjPZMTbDxc46PRwT7o9m3sJ1q70Pf03ohfl eqqYfGNGbjnleNwJ8w7AG1vRb5w+L2fOjob134zJi3TFY2tefM2KYZIxSZK30s5u uwZekUsakvvv7OSYcqe6eKzqUf6CUgb5oMfgNGIVpj2OedjXim6+ZefScLxelyfK 9je6bf1ItFTCPOq3dVvWSFDU5ehpWn/wuMXadZ3lYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeivddgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Jul 2022 19:57:32 -0400 (EDT) Date: Wed, 6 Jul 2022 08:57:24 +0900 From: Michael Paquier To: Nathan Bossart Cc: Kyotaro Horiguchi , tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pgsql-hackers@postgresql.org Subject: Re: avoid multiple hard links to same WAL file after a crash Message-ID: References: <20220411165257.GB1915258@nathanxps13> <20220412.154631.417529439388886590.horikyota.ntt@gmail.com> <20220412162742.GB2062175@nathanxps13> <20220502173907.GB3351307@nathanxps13> <20220502230613.GA3398932@nathanxps13> <20220705165838.GA1232533@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FazpBLb7vCCdfTB4" Content-Disposition: inline In-Reply-To: <20220705165838.GA1232533@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --FazpBLb7vCCdfTB4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 05, 2022 at 09:58:38AM -0700, Nathan Bossart wrote: > Thanks! I wonder if we should add a comment in writeTimeLineHistoryFile() > about possible concurrent use by a WAL receiver and the startup process and > why that is okay. Agreed. Adding an extra note at the top of the routine would help in the future. -- Michael --FazpBLb7vCCdfTB4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmLEz+QACgkQnvQgOdby QH3oKg//ZXPtJRgVU+iG9QvrUQSsWNO8pgOUPdtZdHi6dglFuiAMJJwyeuNV0E7H 8JxuBRxvBVwAmwpzqy/ndU33grJQbkqUoT38v7QiE9IEwrZg71Hkkcp2R6KQNhsR gyMhLdSuVHlrN4phP3KIJwLIyTi8GyIO5D4Pu6uZ64z1akMguViZjePESR3gtVF9 30mzLmbZMOlr1qBmIfDvcGQ9oarfudDG0jg8cclMnNBIt6aDARC1oPQS9nqJUtlA gtmSkLQxvB4Ms/m0enzyDTiJhLI8P2bJw7ZL5MjgRwEe4cmcTcAsKocetbTHc/x7 BnL34NW8k0Y7EMs6ylFE8asRL7AMkKoroCSnMcMfSWGk3C+LLG62IJmftgAVD3Zc YMHfqqEqkGt11PabQGLv2xMCJwKP63dRBPOtEsWVF45DbGrNGsWzOHWdE38+WuDb sRqRT3q7l8/4fjH6PT6LNTvBQ+ttNt0JnLCZXyjpHnAM0NBik6ZhcYDHLzgf1D4D fGaxmnR1ouva2IvCcKNaA0p80AyoUj2HS2QISPaP3Ccw/5q3iTDV7ihzXYZjHfVM 1lKOEzKAhu216oGzjOPxV5+V8sNsWKSz+Q3PAxAhjJh1m8JI5EaObSMXzO5MnOuC F5MkgTbx+4V6T3qhxXX78r6WOcviOj9UXucOVTdJZqG0msEaWZE= =lP4Z -----END PGP SIGNATURE----- --FazpBLb7vCCdfTB4--