Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 11 Jul 2022 10:16:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Nathan Bossart <nathandbossart@gmail.com>
Subject: Re: Allow file inclusion in pg_hba and pg_ident files
Message-ID: <Yst5/P/EpUJdBGen@paquier.xyz>
References: <20220328083330.dmbbujtd3bhj6h7t@jrouhaud>
 <YkJfIAPcBd70bQq/@paquier.xyz>
 <20220329081454.tfa24qf5t5dyzjnt@jrouhaud>
 <20220518070938.pnucjfnp5yr6337l@jrouhaud>
 <YosvUhdMcckC+55Y@paquier.xyz>
 <20220523114308.qxnbjnxox23i5gsv@jrouhaud>
 <Yow4ZREPUyUp76hD@paquier.xyz>
 <20220526072657.7nptqy7ihxk4gkla@jrouhaud>
 <YpgNfzLBV6mdtRSg@paquier.xyz>
 <20220708065721.7q7x7glj3mc37b5c@jrouhaud>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="KZKIOw7ryi9lv1aA"
Content-Disposition: inline
In-Reply-To: <20220708065721.7q7x7glj3mc37b5c@jrouhaud>
Archived-At: 
 <https://www.postgresql.org/message-id/Yst5/P/EpUJdBGen%40paquier.xyz>
Precedence: bulk


--KZKIOw7ryi9lv1aA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 08, 2022 at 02:57:21PM +0800, Julien Rouhaud wrote:

My apologies for the late reply.

> I don't have an extensive knowledge of all the user facing error messages, but
> after a quick grep I see multiple usage of OID, PID, GIN and other defined
> acronyms.  I also see multiple occurrences of "only heap AM is supported",
> while AM isn't even a defined acronym.

A lot depends on the context of the code, it seems.

> It doesn't seem that my proposal would be inconsistent with existing messages
> and will help to reduce the message length, but if you prefer to keep the full
> name I'm fine with it.  Those should be very rare and specialized errors
> anyway.

So you mean to use "HBA file" instead of pg_hba.conf and
"authentication file" when it can be either one of an HBA file or a
mapping file?  That would be okay by me.  We would have a full cycle
to tune them depending on the feedback we'd get afterwards.

> While on the bikeshedding part, are you ok with the proposed keywords (include
> and include_dir), behaving exactly like for postgresql.conf, and to also add
> include_if_exists, so that we have the exact same possibilities with
> postgresql.conf, pg_hba.conf and pg_ident.conf?

Okay, agreed for consistency.  With include_dir being careful about
the ordering of the entries and ignoring anything else than a .conf
file (that's something you mentioned already upthread).
--
Michael

--KZKIOw7ryi9lv1aA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmLLefwACgkQnvQgOdby
QH3m7w/+O6Yve9kTWN1uINvDQ4pxoKueumkitebLD+VX3cNA0rqZnPmtE0fQtLh6
F0QfN4XYhQX2JQCpG+XwYRMeVngA9rSLDl0LrjKpirgUEi2eHsG6IcpTIFZR7FGQ
pZN6tZAGJYfr/WsG0VOKEBb+lszygJoSy0W0311NDn4PPkuxiDSuRVoqiW79JVUX
6dMnFzVSbXf7wqpGqAPWH3QjEEaWR7Px/AO4k/Ch2pbkpAl585ZhNIWQH8YyqWrN
EQdu+pWBCikzLTnMo/dhLZmB2ojeNuy+ZR0nOMJe/DotpswuErWtYAZft4O7GuMt
iJLeozUHVeb45Bl8BykYajgG/FClHP0mEayVzFY4EQJqjdvCYYJyhQeM+GjwODli
RhnB5utImt2mhULZEnyICJBo1PM7bLp+EPl/SalcokuCLJkxwvQXmr6BMj5HHCPE
jhxWjFHHgQG3pjZsxOBeSyvhtksFRifBcnnzWow7YEGt6LyEBZOuLLBmLJO+1o5H
EX4Ey1WlaPKtCvXgCkaBRZOY2cIJ1yYbVvmNB55rNkGhOQEKnSXSh/2hhXFCtuLW
hsf24/YJDS8D5O6oOVv4MbJytlwM2EimmRHRedHMllglmtmMNn+NpbLRnlQkh9cQ
oy5P7sXIiBXL81o9MekQVGzKMnILsS0Fjd9Zfm6kpTljlC4yfJI=
=D6DP
-----END PGP SIGNATURE-----

--KZKIOw7ryi9lv1aA--