Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 30 Aug 2022 08:48:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Niyas Sait <niyas.sait@linaro.org>,
	Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
Message-ID: <Yw1QVptf33FMZw6n@paquier.xyz>
References: <20220826012907.gjw3jdqdgsts5y65@awork3.anarazel.de>
 <YwgrZcEUh6pgLg+u@paquier.xyz>
 <20220826032943.nwoepbegzwntbmks@awork3.anarazel.de>
 <YwmCj/VGXjCeNcrh@paquier.xyz>
 <20220827192757.akupv6cydlgksd2y@awork3.anarazel.de>
 <YwsX3Jf89ucT/VFC@paquier.xyz>
 <2655387.1661695793@sss.pgh.pa.us>
 <20220828154154.4vk6lymdbvx7hnhc@awork3.anarazel.de>
 <2679975.1661701879@sss.pgh.pa.us>
 <YwwSdACDiHqtPkMA@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="7vLR49JRnI6nDLKo"
Content-Disposition: inline
In-Reply-To: <YwwSdACDiHqtPkMA@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/Yw1QVptf33FMZw6n%40paquier.xyz>
Precedence: bulk


--7vLR49JRnI6nDLKo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 29, 2022 at 10:12:20AM +0900, Michael Paquier wrote:
> I have noticed that yesterday, but cannot think much about it.  This
> basically changes the position of "<!--c1-->" for the first record,
> leaving the second one untouched:
> <!--c1--><?pi arg?><![CDATA[&ent1]]>
> <?pi arg?><![CDATA[&ent1]]><!--c1-->
>=20
> I am not used to xmltable(), but I wonder if there is something in one
> of these support functions in xml.c that gets influenced by the
> randomization.  That sounds a bit hairy as make check passed in
> bowerbird, and I have noticed at least two other Windows hosts running
> TAP that passed.  Or that's just something with libxml itself.

This is amazing.  The issue has showed up a second time in a row in
bowerbird, as of:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dbowerbird&dt=3D20=
22-08-29%2013%3A30%3A32

I don't know what to think about ASLR that manipulates the comment in
this XML object under VS 2017 (perhaps a compiler issue?), but it
should be possible to go back to green simply by removing "<!--c1-->"
=66rom the input string.  Creating an extra output pattern here would be
very costly, as xml_2.out and xml.out have outputs for --with-libxml.

Would people object if I do that for now?
--
Michael

--7vLR49JRnI6nDLKo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmMNUFYACgkQnvQgOdby
QH3l8w/+I5sSo3qdQ9sMTkcjJRMmFCthykVCAZULafPj43AYACv7yNJMZC5K+cbJ
Iy0qIgNprRUGq8aUqsjnGlRDqkObKdMUMPBD0Auqil/3moU1hnhSE2lyzPtGvhtp
QEViStfxO4Pxg7cOR/d7NsmX88uZt5SaLi3fN1gPVD/EPZ1MIF6S8bwiiyWAhi8M
GHMg5Q88gtQDFmNns4szqwsXFBwdxJMJl35FyzP4F7/oqqM+ILZoO7bS00RkV26m
EKGwK8RYY2t5uU89xSS4O4hWFy95eNyTXS+el5QK3+mQrFCSUbfxy2GCbsbU7F3u
J9ujYJsVmiEUJqs5VHZW1O2smr1GuQe7d3q1VPNGeQR8Sz5wmLshPTLEfEmCfut3
J+/oIcGJQpREuZPWAiabJlSZmikn5KwvrY7l3KxJWDCHTEHsuabMFh/8uGyTIP9a
oo8HDEBdmO09VOSXlXAHcSE55viu63rPA7gMtPT2KgpQ5hoBZsk7dNZGZI6uhoLc
+WYboT+A8kyFYyLjinRbH+vu/R2HsRchQPMJnl9NpN19nsihReHgBImlYpXrtfBJ
vH9hwhRPfkd5qhjXUuhuO+loHR/0kagmJqaWKLKUTwK2PrfWM1bBz0KaA80CosRc
+23CItzIhlJ/5/yKjrHSH8PeKLUsDm0vFwHuXlwZKpM1Ba6oJfc=
=FE4V
-----END PGP SIGNATURE-----

--7vLR49JRnI6nDLKo--