Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQLQD-0004CF-Io for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 04:21:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oQLQC-0001t4-EV for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 04:21:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQLQC-0001su-5N for pgsql-hackers@lists.postgresql.org; Tue, 23 Aug 2022 04:21:48 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQLQ9-0001ZE-Oy for pgsql-hackers@lists.postgresql.org; Tue, 23 Aug 2022 04:21:47 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id ED15D5C0089; Tue, 23 Aug 2022 00:21:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 23 Aug 2022 00:21:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1661228504; x=1661314904; bh=mCspUeX90e cdn1ukbTCnCpDN0FT4KZRZAOMwBS68AAQ=; b=lYVUhCEUc39sSuWD9kVNIAtPRQ YN/RQrN45buCVgCgxAp9Q6JjaZtni+h6wOIZelGMYQ9J/oh2eTr8xe09uR5sg4UZ ng6b2T077M2oM2o2rWMuaGByXcmbFIPbZiu4d6PBpS86T932lIA2/hm/4VFnUIVN ffs4kS30oudQwxia7uKZdvdKYwHidxh56kKLwo48S51Uczf72rgHcBxAdiVDupV3 Za8ZnCH6gsFwrAS2sMELuUEHXk4Gd5j59Jkd8KBrOdmouAyQscQZTWhvwQn+rDmi sGEccjEh7uqhjtHmWXhEiG847RtPgoCya63JgBqn+NTnqeKDwk5o7CYP0R5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661228504; x=1661314904; bh=mCspUeX90ecdn1ukbTCnCpDN0FT4 KZRZAOMwBS68AAQ=; b=g24/eGrM6La4Hru0+bXC6gRVYFwgZ+gECMh/SZETdAVt a/B1qgSyibHltTBFqk2HDhaIrGOVsRtXgjXnPY1h1gy0NlTBH+he/RajNsujbAB8 c+F7NMxVzjuNY/Z90UFw7kvt21FlEZItfLUt1ZYCC+Z0DobkL7IPwRBq47a6KXFz xin0sYB1yXw1tF1avh513Gm+1ZBclGa1na6O9V6+eET0dQxznsVrf7jkahzDJcJN gqvbVWc4kfYH5/KDYYrRQ49BQK7EBS51yv+F3Pati5qnpkHHzKypkC36yMbpTzBl jR6LPOwtBlX9mfdqrqybK2yDO8a/q7JwUhBqKb0VLw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeikedgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 Aug 2022 00:21:42 -0400 (EDT) Date: Tue, 23 Aug 2022 13:21:40 +0900 From: Michael Paquier To: Thomas Munro Cc: Noah Misch , Tomas Vondra , Amit Kapila , Petr Jelinek , Peter Eisentraut , PostgreSQL Hackers Subject: Re: logical decoding and replication of sequences Message-ID: References: <95345a19-d508-63d1-860a-f5c2f41e8d40@enterprisedb.com> <1882b44e-8abd-8f2f-29a3-21453801db15@enterprisedb.com> <20220807003627.GA4168930@rfd.leadboat.com> <20220807191205.GA16699@rfd.leadboat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YUNvIPMf9jBTBde5" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --YUNvIPMf9jBTBde5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 08, 2022 at 06:15:46PM +1200, Thomas Munro wrote: > The attached patch that simply moves the cache invalidation into > report_invalid_record(), so that it's reached by the above code and > everything else that reports an error, seems to fix the problem in > src/bin/pg_ctl/t/003_promote.pl with Noah's spanner-in-the-works patch > applied, and passes check-world without it. I need to look at this > some more, though, and figure out if it's the right fix. Thomas, where are you on this open item? A potential PANIC at promotion is bad. One possible exit path would be to switch the default of recovery_prefetch, though that's a kind of last-resort option seen from here. -- Michael --YUNvIPMf9jBTBde5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmMEVdQACgkQnvQgOdby QH0W2A//UX09Kx9gRZFi4wRvwRMiiR5rMsRmok1//rcSiR1t1SCGDB3yf4OZQj/F fkHl7vGl1Rnm3nZZRQqJFVsffegyCWSO3qnLqdX7/PrUg1rg5giuscUHytJlF3V+ 1fk2+ZkrfU0mQ+1doISi3ETnTfyjrVO4QsbbhWIYLVVrBWVtOBE6WcRWDqv0myY3 JGacDiPvQsvA0k6MRy8MDsDnnBC+3mzAbntIlrW/g76FlkL1yoCghqtbn4f7iNoZ Yq+PE9RubDyA8zP7TVka3rR8e2tJRsv60rfC7B8Nfbma0tLuiIS8qyZXKRfH9Ngt ZN5jdfTqoyyYWyc0z6g9+s9yFJSetgnl38sOZuYuUfwl3s0JnkuolhX9GgAfCrPv BidUEuotCsj129zDRY2dFI4GoMDNpKBSJUhjzNwoL9fMvAU0gs0WANrFEXkUGsxI ikq/JER9v2OOvyT+movFBWPTglE4zW+haPVsIjMFm3rc0n2k+qbZjngvXSRqzIzm KnGbReoUvRsHBkkaVk2sx1j4ttOQtUOq+McackwlzrEiJqh5is8DQGCBXUlVHgk9 5hF0D2rCWpDA0sAmZbFs8SodN+qxtoqNtJDKZ0uTpsYVyACxAl5qffYYzWJN7rV0 nqhgMm0bETM63gQtSctIkW/NqFdZpiEcQxITOKIGFF5x1ywgPRI= =OMMY -----END PGP SIGNATURE----- --YUNvIPMf9jBTBde5--