Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 26 Aug 2022 11:09:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Niyas Sait <niyas.sait@linaro.org>, Tom Lane <tgl@sss.pgh.pa.us>,
	Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
Message-ID: <YwgrZcEUh6pgLg+u@paquier.xyz>
References: <20220407175359.h7gzgmmnbicq75d6@alap3.anarazel.de>
 <CAFPTBD_+n3C_rrt9Y5mytaw0GJX+SAywMCgKfEpRxpLvzeSMrA@mail.gmail.com>
 <Yl9TmT/Jmz7i2umV@paquier.xyz>
 <CAFPTBD9qPsFMN_Y0HwR+2uRtQGfVnQRa-mxUnAu-MhyEnf8JHA@mail.gmail.com>
 <YmDYdiKlYP0D57ZH@paquier.xyz>
 <CAFPTBD8Mk0X3h0UhWDbN7dLf1-eFeqcE8Qe3SUKzH9b+Gj1kBg@mail.gmail.com>
 <YmX2nJyeykpODEsB@paquier.xyz>
 <CAFPTBD-+YT0wZTh_KJHK+G_DfA9+Y6FrkACkCFz8d4+BZjacuQ@mail.gmail.com>
 <Ynm5g2152/yKc/0o@paquier.xyz>
 <20220826012907.gjw3jdqdgsts5y65@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bbsGSDuzVVVWqjvI"
Content-Disposition: inline
In-Reply-To: <20220826012907.gjw3jdqdgsts5y65@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YwgrZcEUh6pgLg%2Bu%40paquier.xyz>
Precedence: bulk


--bbsGSDuzVVVWqjvI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 25, 2022 at 06:29:07PM -0700, Andres Freund wrote:
> I accidentally did a lot of testing with DYNAMICBASE - I accidentally
> mistranslated MSBuildProject.pm's <RandomizedBaseAddress>false</> to addi=
ng
> /DYNAMICBASE in the meson port. Survived several hundred CI cycles and do=
zens
> of local runs without observing any problems related to that.
>=20
> Which doesn't surprise me, given the way we reserve space in the new proc=
ess.

Still, we had problems with that in the past and I don't recall huge
changes in the way we allocate shmem on WIN32.  Could there be some
stuff in Windows itself that would explain more stability?  I would
not mind switching back to DYNAMICBASE on HEAD seeing your results.
That would simplify this thread's patch a bit as well.
--
Michael

--bbsGSDuzVVVWqjvI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmMIK2UACgkQnvQgOdby
QH1mKw//US4u5H2BLoh9jeB+55MCkFFa5plXpH6wUJuTEJL5o08DNQbjp8PtpRr6
wLQHv0bXdXYNTwH2CEEYXEO1I6xjyKPfFUvokYlxs9wDWvM+pGSHEDHVkelAnTkL
6aRYQ29OrTdK9XwCWjHt8dyku7OGfNSVAnabFzwN4/NGYOgMslFdcZPaXGaISLCj
Esz4kR40ci19zdLsxX09O7kNw3HVvinpEucZad5xaM7ZlW1lKnvs+qW/rYxL0/EI
tOs4uVD7pqcubk1xaFVpDgRACGAz5nOxBFSD9lj7CEHDTSneGjwDBHIg4KfnGnQP
qOA6j2AiLvvlMuJdfFp4BH5wL3EGPBmDB67Dpn7MpIlsBEwZtQVaa1L7Ywi+H8oY
9WmUDgGSY1KrkJax2a8HZ52F52xCi7bvzLTFBrlzaLpp/+e2QuT5+5TP4pNDsGb6
jI9baNXK4ZuMl4qXZ0/+MJtIMzqHlPsIQB54wj3pdhuWU7nS3e1C4BFXFL/x/xzY
UzKi4p9SdFfv99ov5Xjs7JCLXM9vZGXxDc/PVVusav1APqIxvvDJX2RtdhvnZnMh
zQF37lkuXlVpvfQ/463mdhtMhRN5KTXUA/mrnc/1UEcoeCxd+p0mWt542/UooEnr
goCqKhqdasVSRBK6IoBwkM6Oi3dB0Y5FafO1n5HknscOXHL9BDs=
=RsmR
-----END PGP SIGNATURE-----

--bbsGSDuzVVVWqjvI--