Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 27 Aug 2022 11:33:51 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Niyas Sait <niyas.sait@linaro.org>, Tom Lane <tgl@sss.pgh.pa.us>,
	Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
Message-ID: <YwmCj/VGXjCeNcrh@paquier.xyz>
References: <Yl9TmT/Jmz7i2umV@paquier.xyz>
 <CAFPTBD9qPsFMN_Y0HwR+2uRtQGfVnQRa-mxUnAu-MhyEnf8JHA@mail.gmail.com>
 <YmDYdiKlYP0D57ZH@paquier.xyz>
 <CAFPTBD8Mk0X3h0UhWDbN7dLf1-eFeqcE8Qe3SUKzH9b+Gj1kBg@mail.gmail.com>
 <YmX2nJyeykpODEsB@paquier.xyz>
 <CAFPTBD-+YT0wZTh_KJHK+G_DfA9+Y6FrkACkCFz8d4+BZjacuQ@mail.gmail.com>
 <Ynm5g2152/yKc/0o@paquier.xyz>
 <20220826012907.gjw3jdqdgsts5y65@awork3.anarazel.de>
 <YwgrZcEUh6pgLg+u@paquier.xyz>
 <20220826032943.nwoepbegzwntbmks@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="m05mnNzdka33v3y0"
Content-Disposition: inline
In-Reply-To: <20220826032943.nwoepbegzwntbmks@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YwmCj/VGXjCeNcrh%40paquier.xyz>
Precedence: bulk


--m05mnNzdka33v3y0
Content-Type: multipart/mixed; boundary="8+EoCmxEVWQ221vG"
Content-Disposition: inline


--8+EoCmxEVWQ221vG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Aug 25, 2022 at 08:29:43PM -0700, Andres Freund wrote:
> It's really not great that 7f3e17b4827 disabled randomization without even a
> comment as to why...

This story is on this thread, with some processes not able to start:
https://www.postgresql.org/message-id/BD0D89EC2438455C9DE0DC94D36912F4@maumau

> There actually seems to have been a lot of work in that area. See 617dc6d299c
> / bcbf2346d69 and as well as the retrying in 45e004fb4e39. Those weren't
> prevented by us disabling ASLR.

Indeed.  45e004f looks like the most interesting bit here.  FWIW, I
would not mind re-enabling that on HEAD, as of something like the
attached.  I have done a dozen of runs without seeing a test failure,
and knowing that we don't support anything older than Win10 makes me
feel safer about this change.  Any objections?
--
Michael

--8+EoCmxEVWQ221vG
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-Re-enable-ASLR-on-Windows.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 0fde47c2d4e65bd9f1f5a7b4607f8b8b95162242 Mon Sep 17 00:00:00 2001
=46rom: Michael Paquier <michael@paquier.xyz>
Date: Sat, 27 Aug 2022 10:20:53 +0900
Subject: [PATCH] Re-enable ASLR on Windows

---
 src/tools/msvc/MSBuildProject.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/tools/msvc/MSBuildProject.pm b/src/tools/msvc/MSBuildProje=
ct.pm
index 62acdda3a1..594729ceb7 100644
--- a/src/tools/msvc/MSBuildProject.pm
+++ b/src/tools/msvc/MSBuildProject.pm
@@ -347,7 +347,6 @@ sub WriteItemDefinitionGroup
       <ProgramDatabaseFile>.\\$cfgname\\$self->{name}\\$self->{name}.pdb</=
ProgramDatabaseFile>
       <GenerateMapFile>false</GenerateMapFile>
       <MapFileName>.\\$cfgname\\$self->{name}\\$self->{name}.map</MapFileN=
ame>
-      <RandomizedBaseAddress>false</RandomizedBaseAddress>
       <!-- Permit links to MinGW-built, 32-bit DLLs (default before VS2012=
). -->
       <ImageHasSafeExceptionHandlers/>
       <SubSystem>Console</SubSystem>
--=20
2.37.2


--8+EoCmxEVWQ221vG--

--m05mnNzdka33v3y0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmMJgo8ACgkQnvQgOdby
QH2KNRAAmqjnbNHaXZ8MCIx551pOTnHoPJV6ixfaGM9jC/8F1SQBFV9RUpFEg8cM
1McjDvBrw+X9RiUXuX1lbiRjmK2s3Mn08YjkDdAEjxX6SNj/yo+m2jFmNpEzIliM
8HXmWP9QHmTWZioN/0kXGlTuhtC2h1jDiU+zXHUe/sAQSB/e9WZ/AJ85Hd5EsUBz
B2ZjLxXL+LYTK3nCXsx0k7BAtzmcRHSdYMQKveMw1Jo/cauGo6LtLezoSyta0Dbw
GPZc6tiubrW0MyBaklAbZVK5ahFJDOrYuZX/T7Pc3CDB21c4okqOJymVcMc3eaDx
0ChYqPtqybVT560jOQfg5nA1vYZgnPbZuna55O79U9IswTed146i/j4O4C1+dunC
g/ZWeLkX7lPi48JF9sCOQ3XMhKxXHUe7XgMy9ewypnSWGZ/HVYoLMVV8XrM8tbn5
Fz1jOIMQKjdNA2+3iOJCfXRRBO0qZjPHSanu4XPbBWoOOCaWEC/uES7tcLOSrDN/
UzBPVJ7fRPdbQTyuKgUUOHD82aVElyF+EwHa5DYXvNygLykuqIA+MK+1xrs94KPS
jyJ9NHo1Jeop33LyTvVGh+MMAApoI8HUhcaQKPU+a19K1qo1Y4ejRXFZAPubwZAz
MflbTiVam3NCttVw8CZspJUI5W+DKuliGlwLl+v2BwoWYgwN/iM=
=um7m
-----END PGP SIGNATURE-----

--m05mnNzdka33v3y0--