Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 2 Sep 2022 17:09:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Andres Freund <andres@anarazel.de>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Avoid erroring out when unable to remove or parse logical
 rewrite files to save checkpoint work
Message-ID: <YxG6KnN75SS5hKgV@paquier.xyz>
References: 
 <CA+hUKGL30BKpudMLYP++hTvK+O5DirMkwEg6yWQ9BLycKfPUvw@mail.gmail.com>
 <CALj2ACWSjE8AiJ4xaBS4ULQ8T6RevwsNhTD6yPBLugJBTD5LCw@mail.gmail.com>
 <20220816203233.GA255076@nathanxps13>
 <CALj2ACXZPMYXrPZ+CUE0_5DKDnxyqDGRftSgPPx--PWhWB3RtQ@mail.gmail.com>
 <20220823180744.GD1207981@nathanxps13>
 <CALj2ACX0TW4C8gtwFMjyG2r=xnbRUnO5uRWQVscJoZFD208U_g@mail.gmail.com>
 <YwdpW20yC6pMs6fQ@paquier.xyz>
 <CALj2ACV2boDSpQGYvp5Won6qfJgwdpeFMJTO-4Z7dKZy8UAH2Q@mail.gmail.com>
 <20220828215243.GA298988@nathanxps13>
 <Yw8Jg2kv9CaRMbgS@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+RwM3mWgFVf1V9k7"
Content-Disposition: inline
In-Reply-To: <Yw8Jg2kv9CaRMbgS@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/YxG6KnN75SS5hKgV%40paquier.xyz>
Precedence: bulk


--+RwM3mWgFVf1V9k7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 31, 2022 at 04:10:59PM +0900, Michael Paquier wrote:
> Yeah, what you have here looks pretty fine to me, so this is IMO
> committable.  Let's wait a bit to see if there are any objections from
> the others, in case.

I had a few hours and I've spent them looking at what you had here in
details, and there were a few things I have tweaked before applying
the patch.  First, elevel was set to LOG for three calls of
get_dirent_type() in code paths where we want to skip entries.  This
would have become very noisy, so I've switched two of them to DEBUG1
and the third one to DEBUG2 for consistency with the surroundings.  A
second thing was RemoveXlogFile(), where we passed down a dirent entry
*and* its d_name.  With this design, it would be easy to mess up
things and pass down a file name that does not match with its dirent
entry, so I have finished by replacing "segname" by the dirent
structure.  A last thing was about the two extra comment blocks in
fd.c, and I could not convince myself that these were helpful hints so
I have removed both of them.
--
Michael

--+RwM3mWgFVf1V9k7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmMRuioACgkQnvQgOdby
QH3hjA//f6Ayr2woym5yKkTSizZFrPOB4EsGE1h/bJqTxevFO7xd18LDiUgoaYMp
oMTsTCuAvlpfcYrAP6Pc72Mbrsjz01iowyjW+H6lyXb1Ho3DeV6gkKq6Qo8xF5fb
Z3rce1FGmo8Xm2wiirDHVaJlPVE0AtOc7EA+i2bDTpjJx6djqnJdN0MvKUxacsQN
F99nVQGhi0bWghYbr6YuP+gaOwiYB6SIxfKtoHHd48i0lvfW7koFv+/MVfSTl+ni
hzpHf0eCjbkvZX5fFPxDxwcUg/YrEBfV+PuYeMUkCgShLM4D7E6re78ifUSpbiCR
T2m0RvfJLZHrzxy7Qgid4LHroVcVzT7bBDWCUDd6rO4QgsEOiH+evDRu0mcj4es2
unUgqKu+BU7pbv/ROraOiquf2aZY7F7xxLbBnw9IfwMvKbDS3u4mGWE1J1HFzPzf
uo20Asa9AOsc4ohd1fyNpb19Wb04jbQxNsivj9Zcdi4uk+C0D+yFWPNYCv/3F9e7
mfA2ftwhq/k92H00xI4lHwQ+NpXhmA9m4ppmRjeXJqBTsJXszhnjBigMQ0E874pI
X2OwsCoEjUbm44fpioqVNrCGByxPsQ3iVpbu6GHhKyiXeOA6rns4GAN4WZAJDly5
Q17jx9ZNOUi/+9Mk64X9pibohdLk/SqPuf5TguxV9fvXFGwiaHo=
=mgqw
-----END PGP SIGNATURE-----

--+RwM3mWgFVf1V9k7--