Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 14 Sep 2022 14:25:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	David Steele <david@pgmasters.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Magnus Hagander <magnus@hagander.net>,
	Stephen Frost <sfrost@snowman.net>
Subject: Re: archive modules
Message-ID: <YyFlylmDabc/eEH8@paquier.xyz>
References: <20220202224433.GA1036711@nathanxps13>
 <CA+TgmoYJ9pTRdX35E35q=+5zetrpOyBh=QnU532C4zvsL1xWdQ@mail.gmail.com>
 <20220203192747.GA1080581@nathanxps13>
 <CA+Tgmoa+Sp9w2CAkEJ4MuD2sAjePOmVWiYh1yDvVx4P--4ZbUg@mail.gmail.com>
 <20220203211121.GA1081379@nathanxps13>
 <CA+TgmoYDiOPrEAwzf4MAp-RPRo4TgU1MHfuDOBz-FupWfDa74A@mail.gmail.com>
 <20220203212539.GA1082940@nathanxps13>
 <CA+TgmoYE7hSUUMfNwKOzHBQ+x6Ge9ThiDbQHXCZ5ty=fGQf7YA@mail.gmail.com>
 <20220203215537.GA1123901@nathanxps13>
 <9366d634-a917-85a9-4991-b2a4859edaf9@enterprisedb.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="B/tFL8M23NxZ8//C"
Content-Disposition: inline
In-Reply-To: <9366d634-a917-85a9-4991-b2a4859edaf9@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YyFlylmDabc/eEH8%40paquier.xyz>
Precedence: bulk


--B/tFL8M23NxZ8//C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 14, 2022 at 06:37:38AM +0200, Peter Eisentraut wrote:
> I noticed that this patch has gone around and mostly purged mentions of
> archive_command from the documentation and replaced them with
> archive_library.  I don't think this is helpful, since people still use
> archive_command and will want to see what the documentation has to say
> about it.  I suggest we rewind that a bit and for example replace things
> like
>=20
>     removed or recycled until they are archived. If WAL archiving cannot =
keep up
> -   with the pace that WAL is generated, or if <varname>archive_command</=
varname>
> +   with the pace that WAL is generated, or if <varname>archive_library</=
varname>
>     fails repeatedly, old WAL files will accumulate in <filename>pg_wal</=
filename>
>=20
> with
>=20
>     removed or recycled until they are archived. If WAL archiving cannot =
keep up
>     with the pace that WAL is generated, or if <varname>archive_command</=
varname>
>     with the pace that WAL is generated, or if <varname>archive_command</=
varname>
>     or <varname>archive_library</varname>
>     fail repeatedly, old WAL files will accumulate in <filename>pg_wal</f=
ilename>

Yep.  Some references to archive_library have been changed by 31e121
to do exactly that.  There seem to be more spots in need of an
update.
--
Michael

--B/tFL8M23NxZ8//C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmMhZcoACgkQnvQgOdby
QH0Nfw//efz1w/jQm7u39WgbIQZDpr0+3ndtxMIbyeSBcxt0GUQN9HsMP85zK6wg
lQIgsAD3TGKScJ2HsObeNrh400xNQ9TatqskzC2sd4Syp7RYN6nCM8tfMco6Hlke
3BuhCaurleXAV5mfc6HN26K6leb6hdMZr2FUc9fCpwqdBUrYLqgVO1q1lVcxzCmk
rCNC15EXSRVaQF0YyoHRkTwyacnIFm6TRiL0+/ELSl1BOODDEhD9duFSJjOJgGwq
RaeAlznhR/ijC1WhGVtqcBMV13RKV+TIGBpzPZbLRv/x5UEkfCM2C5gPK9hBAJdZ
qXHP0XmP1L9K7/qO7yd8o1pZmsmY/hNeDlyqyy+6CG0pz252ltCDZ6KEweaDO8mw
WbdzCZli0C3uTlYcVNTPziRu3bA3RvGPwI1hdDEE5KX0UjaHhqnyJpwC/5KV+OUg
wRf5CNZAImajq6LveuqcTcWUClrHvbmDZ2RIVWLawb2EL4Zxwlnwnj6evUXaeviE
LpQGwmAGLfRFKai7G/Ys6paaY8AMSZnpkz7mHvrHqngAvA276z8F1IsUhRIcIlRZ
qbqWOTIC/Hf/XCSRoVDF82NGnomy+tCObEwh5aqvkeqxItS6gAMTo6II+kqh5l3k
8l1xJYdKkExMWcvBJCYKX6pOO+SlKiNgT+f/mGKPMXsEsq36Bdo=
=S6mP
-----END PGP SIGNATURE-----

--B/tFL8M23NxZ8//C--