Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYiKO-0004uH-VH for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Sep 2022 06:26:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oYiKN-00015Z-EX for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Sep 2022 06:26:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYiKN-00015Q-1P for pgsql-hackers@lists.postgresql.org; Thu, 15 Sep 2022 06:26:23 +0000 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oYiKK-0007oo-UA for pgsql-hackers@postgresql.org; Thu, 15 Sep 2022 06:26:22 +0000 Received: by mail-qk1-x72d.google.com with SMTP id d17so11774248qko.13 for ; Wed, 14 Sep 2022 23:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systemguards-com-ec.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=Wsk7EINCLhYoaMHDJiP6Unlwq1JP4GE9/YQuNS5Sm1k=; b=JBcEjua//fHu9vWdZt25Hzb4UwF/l067Wvax4HNvsFtQ2UDQgGU11QPjkOj+qhiBZy 3897j5EEt3v3NdjucKKhZyloEJlogubH6jdl8yEWvlLKS13jQXLWpnY0N/ofKMTB72GC oC1xOcI7uR2FpqWTbiwQ7qhullen/wxfGxqgl2I3YF8MAy/r+wnJ1sajbEub0/Q4OoXj 5XOIxLe/5gWLb0vvZKqt5lbiujJe3+NfmyqiwG5NdbtFoG54Pxd29HpfYdq8NiQNQv7L myWapDzgNfVntjNDGwgz017gAqhs+l1AoMS2KfYuPH3uSdjZm7GfaiWFV9XC87Py0j02 VpHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Wsk7EINCLhYoaMHDJiP6Unlwq1JP4GE9/YQuNS5Sm1k=; b=BJnlgmqNKVk7x/A0oWFMyhrtilZFn3ItT2fwWDW3QjBvpjNW0yxfxS4RUs4R6p23Dn XQUEkyOzNacsav/B711yVI6cTDcBcdaX4HZ8NMLiV3DkYcxsoehm7spyJ1y45FuN9hQv fFdZxZPrH+C2rvaS99xINy/KYLi53wfXqwh1EzbLvpRqMq2muYF5sMLQq1oR8vJhjDD3 DTFGB5o3nJScM1t0Z7L9t8rxGYAWNwZ9J4P1+ZB5LwRGnoA1gpK5d6pCPYxJO5Bm4/YS wRefBb0E4NGntrackP3j7C3gkytVPQTUnt2NBaGDBOlpt2opBfquTL0PqpFu0HBMtzxT 5lug== X-Gm-Message-State: ACgBeo3bdxHdjbnBS7le88qLx9eCDV90/MLujFn1vFk9LX/qltKUQZaQ pYdStFWq3XjxRM/UKJsnw1K0hA== X-Google-Smtp-Source: AA6agR79d9dktaYm/tuR0KMu1689fcnZcUfcv/qgOSGBf3TP2v9tGo+Z9VM5S1TsHO7s8dL72pMXMg== X-Received: by 2002:a05:620a:40d5:b0:6ce:3a75:3a31 with SMTP id g21-20020a05620a40d500b006ce3a753a31mr13308913qko.294.1663223178970; Wed, 14 Sep 2022 23:26:18 -0700 (PDT) Received: from ahch-to ([201.183.1.162]) by smtp.gmail.com with ESMTPSA id h1-20020a05620a244100b006cbcdc6efedsm3485942qkn.41.2022.09.14.23.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 23:26:18 -0700 (PDT) Date: Thu, 15 Sep 2022 01:26:15 -0500 From: Jaime Casanova To: Kyotaro Horiguchi Cc: andres@anarazel.de, pgsql-hackers@postgresql.org Subject: Re: START_REPLICATION SLOT causing a crash in an assert build Message-ID: References: <20220907193908.prfnxnt6diao2fli@awork3.anarazel.de> <20220913.184845.2130916662920954058.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Sep 13, 2022 at 10:07:50PM -0500, Jaime Casanova wrote: > On Tue, Sep 13, 2022 at 06:48:45PM +0900, Kyotaro Horiguchi wrote: > > > > Another measure would be to add the region to wipe-out on reset to > > PgStat_KindInfo, but it seems too much.. (attached) > > > > This patch solves the problem, i didn't like the other solution because > as you say it partly nullify the protection of the assertion. > I talked too fast, while it solves the immediate problem the patch as is causes other crashes. -- Jaime Casanova Director de Servicios Profesionales SystemGuards - Consultores de PostgreSQL