Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaS8k-0007KW-EL for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Sep 2022 01:33:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oaS8j-0002Zh-7p for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Sep 2022 01:33:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaS8i-0002ZY-Un for pgsql-hackers@lists.postgresql.org; Tue, 20 Sep 2022 01:33:32 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaS8g-0001Yp-Mj for pgsql-hackers@postgresql.org; Tue, 20 Sep 2022 01:33:31 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 422693200786; Mon, 19 Sep 2022 21:33:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 19 Sep 2022 21:33:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663637608; x=1663724008; bh=dn0y2p1egY CiNGMzWwdRWXTd+MjTNrpxh+XRFjXgq84=; b=Wap5LUFLnZUJlMjzMpk2rgK5q/ 7KhoffLr7zXRmL04TCwFMlYv508CqaVUtE7qH+OzIl0iF0nzqiJTjs3JDitw62pK 6mmqZS52oeWl5hImaCvcm+o9/foyGWCO3zc2j4g7uQtODMBbu2HkO80szVHKRYzI CN2xNGiR1VHwKZLtKQ4IFvGVxx0a9Esqptl/9jYUIWNj+pcyAI4FDgSuYh9TuNyR I+c3hjXO234cuKhVv73S40aQ5vt54A2RZMFSiYjU+u2w69Z8WKqvHlr8GLWUYYHw Tg3JQBbtUWDSfY1km1q6oCF9PRwfHjzJ76oI8Hmzj9FWqhPBycLP23kQ9YWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663637608; x=1663724008; bh=dn0y2p1egYCiNGMzWwdRWXTd+MjT Nrpxh+XRFjXgq84=; b=yy8U1CuVmugGnOkZ+iYn9LmHTypDEm20VHBqyPM92k0x mhtwVQnEJShH0WqQw6eH/8iARqBdvuMrZ8YFAmgsTwJ6nV5tjqqK+UxmhHhY1e7N SttI6cRVISPlJmTbPzS91A/C2iPS8szXZMWq3vmHIyPCPXJSSzN82C8nR2+b9kvJ aCRfbH3KysetpTgJqHMLFcCKlffeZOKmR7F1WGpxDURjcQSeYfUGAXP2dQboRQnX PV/TjocPQI1FTRRODcSsccMTuCNXFUfq+BkRNJ0W147hoYRW2IlfO29hLO2x8/76 IDEI8Fp0Mnl/6GJZbTeeAsCecxBi5xokX6S12lzovA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvkedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 21:33:27 -0400 (EDT) Date: Tue, 20 Sep 2022 10:33:24 +0900 From: Michael Paquier To: Florin Irion Cc: pgsql-hackers@postgresql.org Subject: Re: pg_create_logical_replication_slot argument incongruency Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u+j5tXTqpPFPydqN" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --u+j5tXTqpPFPydqN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote: > This was introduced in commit 19890a06. >=20 > IMHO we should use the documented argument name `two_phase` and change the > function to accept it. >=20 > What do you think? 19890a0 is included in REL_14_STABLE, and changing an argument name is not acceptable in a stable branch as it would imply a catversion bump. Let's change the docs so as we document the parameter as "twophase", instead. -- Michael --u+j5tXTqpPFPydqN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmMpGGQACgkQnvQgOdby QH0yIg/7B7xTN0QgPfrNU2yglZ9jtD0zHOrF7zl4F60o2LFj0cuw8j32PUJ8nH7E ln7e6MFvjFJfmaaocO06rnCZ2d1RAS4ZURTIFjlsk3xQBS5t7VDZKAE5FZ+7j7Jc D2gXjISierM681c0MgLVCkyo7JvT5nrMba2mA7+nbYJIhZD0wqzxK9Ek8xqvWfO+ tbphw4mCxYsTDi4DhgMkx/cj0xS4VbjbueS+PPeeEP97NI2kk11tnKexkK34Vgb6 2Z1gDbsMIKj0cBtjhQ9Cpig8r1xEe8fWMKdT+/I+jibIRFE1QtinclQYrbpQen+z o5QXVaqT0E8COuXGlKcpxEu6l7uYsmerj8tICEiEcuVmbdTArngXSaVG54xdr+sA E+Hxrh7uLotATx1yWuOMhN/7x+hvxcVzaCnENCs7FwzcFBbwW7KMmgCW+4oMIs55 7cnLOjfsByO0cRi4eL3BnjFrtCXt1GpRjY82klaVVSDPBWIJhIkwdHukUkY0g4de eOzhgI+zL3k5xooKGciAU908Q0qyDrIptVKaWZb83Sh7r8wNEJAfeiaL4cMgFyK1 jk2t74aDyAYC2mKVa7CsnN7RqKCXuHX/KhtPNCGM7iXWFGFm842cu2+wT6xBcYUx /HDcG5/RL5VvjAi8XVOagkKDCXu2vg4lOmCIwqStOBHyy1bhwX0= =+6+o -----END PGP SIGNATURE----- --u+j5tXTqpPFPydqN--