Date: Tue, 25 Mar 2025 16:33:59 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>,
	Tomas Vondra <tomas@vondra.me>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	Japin Li <japinli@hotmail.com>, Andres Freund <andres@anarazel.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Cannot find a working 64-bit integer type on Illumos
Message-ID: <Z-MhRzoc7t-nPUQG@nathan>
References: <2397643.1733347237@sss.pgh.pa.us>
 <CA+hUKGLf9CKuAgwKZ4ZBDWvqkSe729D+rXZ-vMpU37-BLso9TQ@mail.gmail.com>
 <2401111.1733349005@sss.pgh.pa.us>
 <2402151.1733349346@sss.pgh.pa.us>
 <CA+hUKG+AyuDcY5BX8uut2id11UDm-V+uwHz--o3h_iF1UKBhZA@mail.gmail.com>
 <CA+hUKGJj71+xFnEF8D26MMYiATNSECdi=3tcpm1kncpmLDJd7w@mail.gmail.com>
 <2412342.1733354191@sss.pgh.pa.us>
 <CA+hUKGKn_EkNNGMY5RzMcKP+a6urT4JF=CPhw_zHtQwjvX6P2g@mail.gmail.com>
 <a6fe6b44-e5f7-4edd-a451-bff69170dadd@eisentraut.org>
 <CA+hUKGKs-QSkM-AnmU55aSrxxrYEDA9A4YoNaE4t4ma-3CAFYQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+hUKGKs-QSkM-AnmU55aSrxxrYEDA9A4YoNaE4t4ma-3CAFYQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z-MhRzoc7t-nPUQG%40nathan>
Precedence: bulk

On Tue, Mar 25, 2025 at 09:41:21PM +1300, Thomas Munro wrote:
> On Wed, Mar 5, 2025 at 6:00 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> I agree with your patch 0001-Deprecate-pg_int64.patch.  I don't see a
>> reason to keep the current arrangement around pg_int64.
> 
> Thanks for looking!  Pushed.

anaconda seems to be upset about this one [0].  I've spent all of 30
seconds looking at it so far, but it appears to be using an old version of
the header file.

In file included from pg_regress.c:34:
/usr/local/include/libpq-fe.h:623:8: error: unknown type name 'pg_int64'
  623 | extern pg_int64 lo_lseek64(PGconn *conn, int fd, pg_int64 offset, int whence);
      |        ^
/usr/local/include/libpq-fe.h:623:50: error: unknown type name 'pg_int64'
  623 | extern pg_int64 lo_lseek64(PGconn *conn, int fd, pg_int64 offset, int whence);
      |                                                  ^
/usr/local/include/libpq-fe.h:627:8: error: unknown type name 'pg_int64'
  627 | extern pg_int64 lo_tell64(PGconn *conn, int fd);
      |        ^
/usr/local/include/libpq-fe.h:629:48: error: unknown type name 'pg_int64'
  629 | extern int      lo_truncate64(PGconn *conn, int fd, pg_int64 len);
      |                                                     ^
4 errors generated.

[0] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anaconda&dt=2025-03-25%2021%3A22%3A33

-- 
nathan