public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bruce Momjian <[email protected]>
To: [email protected] <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Alexander Pyhalov <[email protected]>
Subject: Re: Partial aggregates pushdown
Date: Sat, 29 Mar 2025 18:22:53 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <TYRPR01MB13941CEA16574771B1BFD130595A02@TYRPR01MB13941.jpnprd01.prod.outlook.com>
References: <[email protected]>
	<CAGECzQRFPBsKFk4D56M8yt2TrFdRu_0gDbbBE1887x7LWU_ukg@mail.gmail.com>
	<[email protected]>
	<CAGECzQTx5Ofe8zHXgQHn5cKwaydqHOK8qdWvDyyBPCTnEfvUvw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<TYRPR01MB13941CEA16574771B1BFD130595A02@TYRPR01MB13941.jpnprd01.prod.outlook.com>

On Fri, Mar 28, 2025 at 02:00:44AM +0000, [email protected] wrote:
> Hi Bruce, Jelte, hackers.
> 
> I apologize for my late response.
> 
> > From: Jelte Fennema-Nio <[email protected]>
> > Sent: Thursday, August 8, 2024 8:49 PM
> > SUMMARY OF THREAD
> > 
> > The design of patch 0001 is agreed upon by everyone on the thread (so far). This adds the PARTIAL_AGGREGATE label for
> > aggregates, which will cause the finalfunc not to run. It also starts using PARTIAL_AGGREGATE for pushdown of
> > aggregates in postgres_fdw. In 0001 PARTIAL_AGGREGATE is only supported for aggregates with a non-internal/pseudo
> > type as the stype.
> > 
> > The design for patch 0002 is still under debate. This would expand on the functionality added by adding support for
> > PARTIAL_AGGREGATE for aggregates with an internal stype. This is done by returning a byte array containing the bytes
> > that the serialfunc of the aggregate returns.
> > 
> > A competing proposal for 0002 is to instead change aggregates to not use an internal stype anymore, and create dedicated
> > types. The main downside here is that infunc and outfunc would need to be added for text serialization, in addition to the
> > binary serialization. An open question is: Can we change the requirements for CREATE TYPE, so that types can be created
> > without infunc and outfunc.
> 
> I rebased the patch 0001 and add the documentation to it.

Okay, this is too late for PG 18 but I am hopeful we can make progress
on this for PG 19.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.





view thread (48+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Partial aggregates pushdown
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox