Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tzhqC-005URs-Hc for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Apr 2025 20:04:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tzhqB-005yxN-9Q for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Apr 2025 20:04:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tzhqB-005yuQ-0I for pgsql-hackers@lists.postgresql.org; Tue, 01 Apr 2025 20:04:07 +0000 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tzhq7-002Pfa-3A for pgsql-hackers@lists.postgresql.org; Tue, 01 Apr 2025 20:04:05 +0000 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-6fee63b9139so1826117b3.1 for ; Tue, 01 Apr 2025 13:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743537843; x=1744142643; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hJ0evfq0lR4XdFyT6VCChUXcugFAxnQbYssSbZyB2qY=; b=gBvklaJgM2pq0LplOWO2bv/j0mgihamoKG+5C+Tb9+ewdFZiyCgMbwU73lMLZp+bm5 QVYHAK7JKIEsfcQUvOGgD5hcyEWyFnMN+QpdIow3cmVu61qcVK2RWqymiPdMQn1ccH2Q 8OjbB8gpR9cArE5wi5zUXhiiFlKaNBpDLhtoRKE3Pu21z+NSrRjR+gP7aayzdqK8KuLV CAXr4ccq8Jrpwk2RAELuXKmh7IDhnSzPC65GlghSZ2Tp9HCj/Y0dguhEAMmuzCK6ofAD 87QHeWToMGqpCOdD70+DTXM7pa45XXA9/RYUYssyRRpjEUao+98LlzcmwFhI2Cl+qUYb TnIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743537843; x=1744142643; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hJ0evfq0lR4XdFyT6VCChUXcugFAxnQbYssSbZyB2qY=; b=tm9lageyHfy0tkOqM3dVoTUJDNFDR3wCzlZfVPqLiD0VgsRf/+jkOMTmrPOlfGsYA+ qY6lcXfFFdDH9l2/7cXJeA7wUP+uf/Ivnby9ReuVHm6kzxgn4orEbjGt2CLkvfTDaV2e bxLyyYkUNd4/B8iYJRD6mWQTWCvkHGDaEGEKpjQIlMwyaMavYoFHmgu/rkBj1r5a/mQc ZbEakUEWTMczXHw6gnB0VyldygTPevfEIQzeihFwsR9rFXHhP1UK94qsxoHqG9c11DkI T3pZBvg71n0XEi0ai3d1pKzHgaWMyyRdTwDknW1X3LpbsDF5J7sYLVyabKaDrp4x9OLw 7Gag== X-Gm-Message-State: AOJu0Yxatu6vxsfl+vfLFKw5fhD3hEhznke1xZxI2KIXFbNCiN13zTSw +1PzqaeBhCkSTKeJIjEzq4IKtgT+lnlYxbuRZg+iL5FyFjcsBFei X-Gm-Gg: ASbGncvPGDJM4APfe94hJKRtRBXaYuQRzkRIIXkfaU0QqHeFab3x6GqNEkkOfLchGnf 86P9EOeIyLjRRSHt/m2b1vpLU1iDyw5trUm/GwCfBlbpZ51nG2K/ScdfNzsRQtR9BW3VzdSVfSQ J3Sr2zLz+iib5P0DxXNjbc9sVpl4W9fN6cVw78gBrcgQ66Rm+EFnLyv/xrNz2qeBF5SZdKNBJb9 8cnQqQAG7bq3b8HKHZL6AyEVo4exdVhpAlIWYGqg2VqppAOvIxah6OMR+Jp1Cu49d4YVwvwjrAC nXMzFm1mh9YYOIDaxhvaZfVEr0Qah3ks3VYSl/hmbIC9jhD6e5Cvy11/U7xMwxJjPs2nQ1dZcss bWuS7AxTAQeDNTfDFXhojukCapTC3OLeDiDA= X-Google-Smtp-Source: AGHT+IGtskSrXi0Pla/NWIct9vztkPQ6pPtqX4sXwe2t3SK9/Mph8FFc0VwUmptqFI1PNh26FIupzw== X-Received: by 2002:a05:690c:d89:b0:6fe:bf32:a427 with SMTP id 00721157ae682-703b6400944mr23862757b3.0.1743537843054; Tue, 01 Apr 2025 13:04:03 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7023a37135asm28903217b3.17.2025.04.01.13.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 13:04:02 -0700 (PDT) Date: Tue, 1 Apr 2025 15:04:00 -0500 From: Nathan Bossart To: Dimitrios Apostolou Cc: pgsql-hackers@lists.postgresql.org, Tom Lane Subject: Re: [PATCH v1] parallel pg_restore: avoid disk seeks when jumping short distance forward Message-ID: References: <2edb7a57-b225-3b23-a680-62ba90658fec@gmx.net> <465a7ab4-2a61-ebf9-5779-1733d1c12903@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <465a7ab4-2a61-ebf9-5779-1733d1c12903@gmx.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Apr 01, 2025 at 09:33:32PM +0200, Dimitrios Apostolou wrote: > It didn't break any test, but I also don't see any difference, the > performance boost is noticeable only when restoring a huge archive that is > missing offsets. This seems generally reasonable to me, but how did you decide on 1MB as the threshold? Have you tested other values? Could the best threshold vary based on the workload and hardware? -- nathan