Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIOx0-00E6mp-Uj for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Dec 2024 09:12:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tIOwx-008dyS-0F for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Dec 2024 09:12:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIOwv-008dyF-Qj for pgsql-hackers@lists.postgresql.org; Tue, 03 Dec 2024 09:12:07 +0000 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIOwt-000nzT-6w for pgsql-hackers@lists.postgresql.org; Tue, 03 Dec 2024 09:12:06 +0000 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfhigh.stl.internal (Postfix) with ESMTP id EF83E25401A3; Tue, 3 Dec 2024 04:12:00 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Tue, 03 Dec 2024 04:12:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1733217120; x=1733303520; bh=EXoZv38izh PlQLZoBVQ9m8Rl2ez3XxBwRS9QehSiPo0=; b=P0+W+kN3NNcI/V+NgzVSjSCTtI C7fzUsMLLFZRRfotOttB6bI86OU3uVMrkZ0FqdYNvZ70cKQC1L9TIbmSRcWAqNDP zU2Iz4rpQK6T07McrhqttRO0VfSbjO1Gp5vSYGhkryW0cofOJhwcoOS1RTFE7lnV j/QVPh8vU7MUU5AN99MLRMsjashAv7MHGq15QYS+7kHuuVDujmF+Sbl+p6O1rc1i LavMUNWU2z6X3bu956vJ9kPDP62F5hP10OzRLwmAIFChEYl8sKuA3oteRkOHxKTy Xcae3au2EJGwVYXHthCFnZLzuUXMsgFdl/ss4GHyWXIBADHy17Yk2IqrsYig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1733217120; x=1733303520; bh=EXoZv38izhPlQLZoBVQ9m8Rl2ez3XxBwRS9 QehSiPo0=; b=kTV9KxqQVB0wTMiw7HwXohinnkKLz1Wqyaa0VpbuNBHU0JP8yBR +nko0QFER+H0eqtbqiuIutBHZ2oPjaZCY6mVw4AQbFqIuXb2gUMgq+T7zecdAdYX YYBoxcgqtMZXHtOuAUZ6o/5NWDGE2MtAk2aJFo1zgJMopFKvlfVEDB0GfnNix+xF mgcIWKsCGkEQC99QXX9tFdUKYySpZ1ao3bJQnAOWIUFNgHzHr/BR6LKewrnFxB+R Kj6XguBih23I/EAtVK5lbe6ZLXlkpKnOrCop0xG8LWNFMS0esw6HbrsgL3c+yXz8 XC5rbX9UWV0k+wq1qh0uTnIy2fSCcVxJgug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddriedvgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenfghrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhgg tggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoe hmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleei fedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedvjeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehp rghquhhivghrrdighiiipdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuth dprhgtphhtthhopegrmhhithdrkhgrphhilhgrudeisehgmhgrihhlrdgtohhmpdhrtghp thhtoheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrghdprhgtphhtthhope hpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Dec 2024 04:11:58 -0500 (EST) Date: Tue, 3 Dec 2024 18:11:43 +0900 From: Michael Paquier To: Amit Kapila Cc: Alvaro Herrera , Postgres hackers Subject: Re: Memory leak in WAL sender with pgoutput (v10~) Message-ID: References: <202411300828.hwe55pzx5a4x@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yIfyo/G9bclqQZy7" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --yIfyo/G9bclqQZy7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 03, 2024 at 02:01:00PM +0530, Amit Kapila wrote: > As you would have noted I am fine with the fix on these lines but I > suggest holding it till we conclude the memory context point raised by > me today. It is possible that we are still leaking some memory in > other related scenarios. Sure. I've not seen anything else, but things are complicated enough in this code that a path could always have been missed. -- Michael --yIfyo/G9bclqQZy7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdOy08ACgkQnvQgOdby QH1dNg//cmP/+PdZiEVKfBE3/agct9wGL2EbswSouuLIgCD75u6xfZJHTALfmsOt 7qMCTWOhouvpBU90JCx2xqYIm/A0SIQnwGNwzhWd5gTJYwsexk8sbTZkPssLVIDw E57OlpSI1fmNKdRg0iCZ/cTo7Q70kY6JRAtVST7x7Npz0ORxHyP9CD4yxqrKqCeI QvkzdZt8XwWx3LeAkJabd6adp1QkfSRHG7XTBLF05ViXQXpKt3qfca0tgr4apeq9 P4wkcCXk7zkfVyz5yEdAbvsxjDvHhLxDU4zZcLlm2tvqud4rk6dXRIfFf+ayK0LY aGsWkZqfeJ62+Ud3rSRV1HqxpyC/T9QQyWVvTwCnx3WfFmd3YBq6bYmP4L+xBDCq 5v89K3bN7apLi6hX1ht0Q+NBJOZElbNUIr3o2wBJQDyU3unYZlNJ75DJcUP9fCaF r0GW1tVTke5VXumoioSA3cyNHjGYkUbsSWPrq9Dn7k218iFYYixJE3YUifAC30Au 9bSES9D7lQ4DhoawMn81jUYHeg/3LkeqSUlD8HU54tY1PuEeZxMRCz3eReGcclTN /1b7L0839eKBclpocDic1IjxVZmbxCaZksUZyb167ZkkTOgGBcjsvaK7LCA09p2b qawyz1Y2HWZZO5frVaSzMHbrOemlImeyJtK/cbWNvW3R14LXt3c= =1IGk -----END PGP SIGNATURE----- --yIfyo/G9bclqQZy7--