Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tFeW5-00Efv1-1U for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Nov 2024 19:13:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tFeW3-00HGsS-59 for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Nov 2024 19:12:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tFeW2-00HGsJ-Nz for pgsql-hackers@lists.postgresql.org; Mon, 25 Nov 2024 19:12:58 +0000 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tFeVz-003jnn-V0 for pgsql-hackers@lists.postgresql.org; Mon, 25 Nov 2024 19:12:57 +0000 Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-466943679bfso8881671cf.0 for ; Mon, 25 Nov 2024 11:12:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732561975; x=1733166775; darn=lists.postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nCUCXjJNMZBAvE8Rb7H7ybv2azMBTZLbY1RzZCLbQdY=; b=bZ904DJI4N1vH5QZh9BxQUJ1GCBLTZtFlemGG/brKzCY0qKzIWaK08LyaWQquFqW+x 7JF7ZyGWhJp1m6Af4LhPiBkBmfUZVN+bUBq/uBTkQF7DLdoGhVtEa0UtEPcgkD3IWJZ7 jDSdcOFU+p8KOBDkPxDwkM1qhFQM5kbL2aUIvv20t3Yam3j4aEL4yWnQVWnLQF/Q+yI2 i81ITSk/dp+genyorH741ZYpXxACmeM6wEAibdrnRN7wNhyRGIBZ8cQJqgg6EehbpcRs LVREUBTfXPKEcxrTQi5q3Iko1oMaXP6jipRUZwXo+f1gyDHPnxQDrco5vzIyZBnY5kA8 akzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732561975; x=1733166775; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nCUCXjJNMZBAvE8Rb7H7ybv2azMBTZLbY1RzZCLbQdY=; b=RbJxWF4wV4k2TdHyT+m4a4Sw+pQBZevPeQHPeQepKOdOtfUHNLW6ieRwWC/1JQqOdR sSx7iqALgsc+B+LEBGz6n4E326CNjVCXKVMJV8qxRShelfpvy2mccm/Nhlgb842BhYae GJH4+PjuRsSNQo6BgBIpOT/BqFjjga+AFCrCK3vjevwgKI03L9TEPybTUkH2o4Ak3/9E Lkqt9cVKdJM1V/HTjNNY3VxRKaZSqPONqTltpZqmXtsdBZqY1oAYSmknqqjL9WDnB4dJ zPKq8bsY3eOpv/mbxijh49KnGBlBHs63sJ68yNdZ8njjdofEt+dNr/SD4YY5FL7FBJcW 55oQ== X-Forwarded-Encrypted: i=1; AJvYcCU+ICkIoIZwhXGaOwzNd/CJ4Tw/z3KtmOIvx0Jf82wwfLYiD9kymHP5DhxMfco6O4aAc6uv2DUbZyzxoUgV@lists.postgresql.org X-Gm-Message-State: AOJu0Yx0ZHUQ31W6lCgujmwr47gdTwA0CcW8uULV1inQTZj7//4A1P+H HTfg7JVUJ4nZNqkK5ZeYBfGQgHHFOHbVZxbC15NCcS7ftZAqPHeA X-Gm-Gg: ASbGnctBu/dav7q56aOezEkJCWUxAhm8Uw5Unu4g6NoZrrrVgU+WqgriLrZ84u27LAf QIEkMG1hA5HHzDhLrtbbAFNV1BBT+rRDsne8IaMDeLRE4yaFCe+jNK30ZbHf1M2IXV+42qe3uEt ZJCfAIIbSybyEdq5QRPl7DecBWKg4AA5Dd6qe+Xe147VJAyEPkM/J3049hcEWfpW+2UpLp/WJNV Friy8qmswdvLDVSwXTPAJOk24DRkg40LIc3obR6y1uH/AqujImKn1u0BRAUPXJrL31T9qAN7fnu H93gkK01pxuD2Q3k87ZktPL8mBNDLTUUSU54dViD X-Google-Smtp-Source: AGHT+IGoh3LyhssSEnHH/fCnigIOBimdv2oth2S5owFZAzZ/WR9gP67Cx7QLqImaY7q+gTX2jWJgNA== X-Received: by 2002:ad4:5bcf:0:b0:6d4:2737:6c11 with SMTP id 6a1803df08f44-6d4513459d6mr191725146d6.39.1732561974931; Mon, 25 Nov 2024 11:12:54 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d451a97da8sm45754106d6.46.2024.11.25.11.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 11:12:54 -0800 (PST) Date: Mon, 25 Nov 2024 13:12:52 -0600 From: Nathan Bossart To: Jeff Davis Cc: Bruce Momjian , Corey Huinker , jian he , Matthias van de Meent , Tom Lane , Magnus Hagander , Stephen Frost , Ashutosh Bapat , Peter Smith , PostgreSQL Hackers , alvherre@alvh.no-ip.org Subject: Re: Statistics Import and Export Message-ID: References: <3b3ccbda0b23d5ae0f8e2f6a7ede96f7ed405595.camel@j-davis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3b3ccbda0b23d5ae0f8e2f6a7ede96f7ed405595.camel@j-davis.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Nov 25, 2024 at 08:11:09AM -0800, Jeff Davis wrote: > On Fri, 2024-11-22 at 15:09 -0600, Nathan Bossart wrote: >> I took another look at v32-0001 and v32-0002, and they look >> reasonable to >> me.  Unless additional feedback materializes, I'll plan on committing >> those >> soon. > > Those refactoring patches look fine to me, the only comment I have is > that they are easier to understand as a single patch. Yeah, I intend to combine them when committing. -- nathan