public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: Karina Litskevich <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Use more CppAsString2() in pg_amcheck.c
Date: Tue, 26 Nov 2024 09:49:04 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACiT8iYzjeiziq+pWcRH=fT4g5zSzr5A88QQsRCuM659NQCwrQ@mail.gmail.com>
References: <[email protected]>
	<ZxKZUprDJOkRmET4@nathan>
	<[email protected]>
	<CACiT8iYzjeiziq+pWcRH=fT4g5zSzr5A88QQsRCuM659NQCwrQ@mail.gmail.com>

On Mon, Nov 25, 2024 at 06:25:46PM +0300, Karina Litskevich wrote:
> The patch looks good to me.

Thanks for the review.

> They are not identical: space before AND vs space at the end of the
> previous line. I'd say that it would be better if they were
> identical. Personally, I prefer the one with a space before AND.
> Though we have two more similar cases in lines 1974-2001:
>
> And I'm not sure how they should be handled if we choose a space
> before AND. Does the following still look fine?
>
> What do you think?

Both look the same to me, TBH. :D

The result in the queries generated is also the same before and after
the patch.  I see the inconsistency in style, but I'm not sure that
it's worth bothering about that.  Applied v2.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (8+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Use more CppAsString2() in pg_amcheck.c
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox