Date: Tue, 26 Nov 2024 14:04:15 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tatsuo Ishii <ishii@postgresql.org>, nagata@sraoss.co.jp,
	peter@eisentraut.org, daniel@yesql.se, pgsql-hackers@postgresql.org
Subject: Re: Doc: typo in config.sgml
Message-ID: <Z0Ybr9iRBkOUYOGZ@momjian.us>
References: <20241119112907.1cdfe086df16e7ac173f9571@sraoss.co.jp>
 <ZzwA_DayripquW7e@momjian.us>
 <20241119193121.7ba727c489b5f0b6d20f9c25@sraoss.co.jp>
 <20241126.182513.1752581942460106099.ishii@postgresql.org>
 <Z0X5xYJ_dvkREogb@momjian.us>
 <1682864.1732639382@sss.pgh.pa.us>
 <Z0YApkVlEfHYOaC4@momjian.us>
 <1689262.1732642897@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="HpkrNr5+cKEDw25c"
Content-Disposition: inline
In-Reply-To: <1689262.1732642897@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/Z0Ybr9iRBkOUYOGZ%40momjian.us>
Precedence: bulk


--HpkrNr5+cKEDw25c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Nov 26, 2024 at 12:41:37PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Tue, Nov 26, 2024 at 11:43:02AM -0500, Tom Lane wrote:
> >> I don't think this patch is doing anything I want at all.
> 
> > Gee, I kind of liked the patch, but maybe you didn't like the additional
> > complexity to check the PDF output twice, once on input (complex) and
> > once on output.  The attached patch only does the output check.
> 
> It's still not doing anything I want at all.  I'm with Tatsuo
> on this: I do not want the makefiles deciding for me which
> warnings are acceptable.

Okay, how about the attached patch that just prints the message at the
bottom, with no error.  We could do this for all warnings, but I think
there are some we expect.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"

--HpkrNr5+cKEDw25c
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="latin1.diff"

diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile
index a04c532b536..cffb06317f9 100644
--- a/doc/src/sgml/Makefile
+++ b/doc/src/sgml/Makefile
@@ -156,7 +156,9 @@ XSLTPROC_FO_FLAGS += --stringparam img.src.path '$(srcdir)/'
 	$(XSLTPROC) $(XMLINCLUDE) $(XSLTPROCFLAGS) $(XSLTPROC_FO_FLAGS) --stringparam paper.type USletter -o $@ $^
 
 %.pdf: %.fo $(ALL_IMAGES)
-	$(FOP) -fo $< -pdf $@
+	LANG=C $(FOP) -fo $< -pdf $@ 2>&1 | \
+	awk 'BEGIN { warn = 0 }  { print }  /not available in font/ { warn = 1 }  \
+	END { if (warn != 0) print("\nFound characters that cannot be displayed in the PDF document") }' 1>&2
 
 
 ##

--HpkrNr5+cKEDw25c--