Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 27 Nov 2024 15:33:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: per backend I/O statistics
Message-ID: <Z0a9QuH8HRLfT5kY@paquier.xyz>
References: <Zz0m1k03k5LA_c8S@paquier.xyz>
 <Zz3wIuQUJysX5O3d@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zz5gMM9w59guO9S_@paquier.xyz>
 <Zz9sno+JJbWqdXhQ@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zz_gHQ2g8MUe8oJ1@paquier.xyz>
 <Z0A3pmORCbhRe0Ug@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z0PNpAjhcS7S-1LI@paquier.xyz>
 <Z0QjeIkwC0HNI16K@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z0Qk3nZcaVpbtCKU@paquier.xyz>
 <Z0ScL5W6EeWXShb3@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="7bUVhIOXHW/mro9i"
Content-Disposition: inline
In-Reply-To: <Z0ScL5W6EeWXShb3@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/Z0a9QuH8HRLfT5kY%40paquier.xyz>
Precedence: bulk


--7bUVhIOXHW/mro9i
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 25, 2024 at 03:47:59PM +0000, Bertrand Drouvot wrote:
> It also takes care of most of the comments that you have made in [1], mea=
ning
> that it:
>=20
> - removes the backend type from PgStat_Backend and look for the backend t=
ype
> at "display" time.
> - creates PgStat_BackendPendingIO and PgStat_PendingIO now refers to it (=
I=20
> used PgStat_BackendPendingIO and not PgStat_BackendPending because this i=
s what
> it is after all).
> - adds the missing comment related to the PID in the doc.
> - merges 0004 with 0001 (so that pg_stat_get_backend_io() is now part of =
0001).
> - creates its own pgstat_backend.c file.

I have begun studying the patch, and I have one question.

+void
+pgstat_create_backend_stat(ProcNumber procnum)
[...]
+   /* Create the per-backend statistics entry */
+   if (pgstat_tracks_per_backend_bktype(MyBackendType))
+       pgstat_create_backend_stat(MyProcNumber);

Perhaps that's a very stupid question, but I was looking at this part
of the patch, and wondered why we don't use init_backend_cb?  I
vaguely recalled that MyProcNumber and MyBackendType would be set
before we go through the pgstat initialization step.  MyDatabaseId is
filled after the pgstat initialization, but we don't care about this
information for such backend stats.
--
Michael

--7bUVhIOXHW/mro9i
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdGvUIACgkQnvQgOdby
QH2CqBAAj6Vo0XaL9DNsBBbqS/wn3P1Mir/NrmZ7Cz7k/AsMu3ptAkRAG+sLSf39
FT8iT3ZDMdDEeeYdlbTCs1+JZ+JBQ35HK8zIr82VGvZKJtb8LwJKy64TKF0Aiooq
BLjZReA+UaFnsSfJVVAKheMw6d2VOuElmbsGfPJmqSI9d5KMCa8a7TVq/COnBXHs
BO7vsMVrr9SozTUkiY8mwKIqs2D6E3cpCxJoPvtsJFSRhhxlntcQFEtsupff5dZp
GfqS6A9WRyVQLAsv/8J/A8L+JG0Jml9XQtFNwCJrNCS4CLkpknROtmcWf0IIzKI7
25V6W42FoaD9wCK+VfQVlqNfCfYr4jX0eTfftbahyOlWvM+B2X0uxCXC6lYooxdO
jCGU+4Tnq4LUVbmeXwUOwzNFbNrbp2W1Ur7icIIRSrEtpofRqDxs2KA5c7Axp1Nt
fZCT+ODdBOGQsiN/z4OOEP3QXl4gF72huqhlF3KC8NeJm2n9ZXyHqr38kw0wpKLq
U0EkIfZCDA62ZGvPeXVLdUlTMbGnt+rJgIJcin5BqkpqaYydcBFmf3wmynqQ28jp
OFeYJhXiQkPYFbGHAatMrRUYLbOQIu9ebGyGI4rL8JL6MmHTKFp5DyhtxspRjL1A
Zoyqtoxm6DM8mlU29Tu1pFp1qfEfvxTnKhMlSbiZPylFxBebaKU=
=yJQC
-----END PGP SIGNATURE-----

--7bUVhIOXHW/mro9i--