Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 28 Nov 2024 15:43:04 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add Pipelining support in psql
Message-ID: <Z0gQ-DYex9dbsBWe@paquier.xyz>
References: <CAO6_XqroE7JuMEm1sWz55rp9fAYX2JwmcP_3m_v51vnOFdsLiQ@mail.gmail.com>
 <CAGECzQTjCEXpJGOq9O6Nf+p4zRwjt-b1p6kACWVNJ+uYcLGvyg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="inXsoNHlz2rto14u"
Content-Disposition: inline
In-Reply-To: <CAGECzQTjCEXpJGOq9O6Nf+p4zRwjt-b1p6kACWVNJ+uYcLGvyg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z0gQ-DYex9dbsBWe%40paquier.xyz>
Precedence: bulk


--inXsoNHlz2rto14u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 27, 2024 at 01:45:32PM +0100, Jelte Fennema-Nio wrote:
> I played around quickly with this patch and it works quite well. A few
> things that would be nice improvements I think. Feel free to change
> the command names:
> 1. Add a \flush command that calls PQflush
> 2. Add a \flushrequest command that calls PQsendFlushRequest
> 3. Add a \getresult command so you can get a result from a query
> without having to close the pipeline
>=20
> To be clear, not having those additional commands isn't a blocker for
> this patch imho, but I'd definitely miss them if they weren't there
> when I would be using it.

Hmm.  The start, end and sync meta-commands are useful for testing.  I
find the flush control a bit less interesting, TBH.

What would you use these for?  Perhaps these ones would be better if
just applied to pgbench rather than psql where it is possible to pass
down custom SQL sequences with input files?
--
Michael

--inXsoNHlz2rto14u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdIEPgACgkQnvQgOdby
QH3UcRAAjSSdwdC2X3pRzl2W/2VUjLl3uMxjVgYaD3wY6s1Gljf7V9K36Krqn9RD
25pYx9TsGrcoWBgJXQVvj/xfzargSuATo1Z9+kHP8I9bOKylO5cf4KwIlTtToFFb
1qKti942tM4iB60kNrcbQlxthcmUas00i/MffofONHiA60KEQ2m+h3SpHJ5nchA1
QjfvLHAbnEw0zgL5DuL0G/Fhx3z1kXjnNoBnE9IT9VjD8zfM3qS/y1exhJFkiXwY
vO9QIEPBGUL9aP1AZnFdWCotXX5E/xLq8nH7RNZ322WUKcZX1I+41Yw9lQCERN6n
B018p9ROWJQsBdXVRAOywRKLRZd0ndStziI7Koc4jVf6/yKepu9HcPCrRB1lvcxL
9ucuu7FYXglmSY6tT5ztF62LvZDIkP1K9rZpi9eN2lDXfnrMDR+CUYACb00Ddwj2
SGQGY7MWALkkUxnCYilDWLzmWEqd05jqSwi7tEXPxCLQW8TAA7voUvQNSiBqr0aB
LHHVb4MUjPY+IbLH1pGlAOfNSNEUV/7V7Tpu7h+Ms9hdv1LWwclWQfxiGaeyiKMb
wmQCpFkC8YqcUGgTnh1ZZQlea23+SXY401GkqA6S2LgJc7dh7YAj7C632zgXt93I
6ghAoenKdZG+2cb89W+VRKs6hylKdSazpz1fg0jkmRK43m2nIxk=
=RG0C
-----END PGP SIGNATURE-----

--inXsoNHlz2rto14u--