Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tMJaA-003STw-Nd for pgsql-hackers@arkaria.postgresql.org; Sat, 14 Dec 2024 04:16:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tMJa7-00Gjr7-Tu for pgsql-hackers@arkaria.postgresql.org; Sat, 14 Dec 2024 04:16:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tMJa7-00Gjqz-Ju for pgsql-hackers@lists.postgresql.org; Sat, 14 Dec 2024 04:16:44 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tMJa6-002jlS-Fm for pgsql-hackers@postgresql.org; Sat, 14 Dec 2024 04:16:43 +0000 Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-844e7bc6d84so47473439f.0 for ; Fri, 13 Dec 2024 20:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734149802; x=1734754602; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XyRmpn4R30xb3C6dszsebNhOqyLVU/rB4LFHsIt+S24=; b=YyGAq8LoLf+xGlQHB0ZDCaaXG4TgQgsrwsFbzrX6V1b2r91XAekSJrRyiflcPH7NKF SaKeT7DPFl4jkilXfZ9jkou+e6VY35r8tFlArT1dPAq5kqLMlxG2wP4K2TNSipx+m3cN AIY9ISZphIIWMKnSOGPMG+eJbnbjVuw3NCKVwLzevXjC77RPp3SE9Fh9EJED6mBdnb4S Ix/ZxWW2eb1OtNJ+jRsHyqsJqXCMYUGHGX0YsvuhAE+5u6qp35IL09OA6gOP13VaUuGH AVytTTc+E3tlehPQ+VSp+m96lpbiukqhEbXSO1zqf1n4fGjmgenPdEq4vLG8ypPhydlh U3dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734149802; x=1734754602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XyRmpn4R30xb3C6dszsebNhOqyLVU/rB4LFHsIt+S24=; b=LMm5z4+IfuZvevqg2rEd7HIU4NZZ8QsIp1JUc28QRB2TdPlQd362GS7bXcrmdBtdNO /qlLNRT6wsgUd1hwE2sH/GxYxuJbajtZUQhICpuf5jpS7VfOY0IGLwhGcJJj0qMgHMTG POhtpinqeQFCuZuKYfc9zte5y2jhKG94TWsgpVB1KWCP6o+SMNw0+d35Ny2gbyI5BZTK S6qb/rAc6W9NxOINmkhP+tG2+dt7BHGBjYfxa3GryWHyn66klyvB2c3XJmGN07ACKJdO Za3nwPoNz0SWk1lnb39MgAAkbF84JHdGaXE49ZIu/t0UYbHnRl0/d+OVVCG6tonqsAOn z9MA== X-Gm-Message-State: AOJu0YzYCuLkJgblEOJIb83mhuHyVcS1pk3nOUHeo3J84GDfs8hoGM/d tk1Y964Rp2sOnAAGLNgP3RLmaFkw2jZyDruwD2domOcsj2qcDAGY X-Gm-Gg: ASbGncv/0TDIkFoUjUPItnMc62/ZQwOYeVQwJXT1fq+l7GUUoi78cIMaIamDFdjR/vB K9hWnT/M6s3XgjTu+dSP2q08H1Qm6y9tXwgJKQo/wD7Nr3/8L8wXMALMl91rX1W4QVvZghBAFdP V4ZdQurwqm5AtpPFG0w4nT+BIa0XQ3d3yKWRfO02Gc72Fl+IKXwn/JJzEGCJ54mHcA6vi0Zvv1y UXV+ac9xzk72RbsI2ljZDRHmj4vQy/+pRA6UX5fpg4a4yGKvED7PC2k6LzrJA0EFOiU6/PpWSiL mVpuFMqKZc9s+AILMdpLuQxdVA/YGRewSAcfsDN7Rq6mxUQ= X-Google-Smtp-Source: AGHT+IEj8QLNwtuZxdZPujKh/FjQLgrfxCv0Fi+gQQJr/IMogJGCG//BF14HfpTZIgQUAFaIS8Q6ow== X-Received: by 2002:a5e:cb41:0:b0:844:2ef3:a95a with SMTP id ca18e2360f4ac-844e5b6e500mr675943339f.7.1734149801874; Fri, 13 Dec 2024 20:16:41 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e5e03686c6sm195111173.15.2024.12.13.20.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 20:16:41 -0800 (PST) Date: Fri, 13 Dec 2024 22:16:39 -0600 From: Nathan Bossart To: Noah Misch Cc: pgsql-hackers@postgresql.org Subject: Re: Fix early elog(FATAL) Message-ID: References: <20241208034614.45.nmisch@google.com> <20241212033414.e0.nmisch@google.com> <20241214031505.05.nmisch@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Dec 13, 2024 at 10:14:43PM -0600, Nathan Bossart wrote: > On Fri, Dec 13, 2024 at 07:15:05PM -0800, Noah Misch wrote: >> I don't feel strongly either way. I did write it the option-1 way originally. >> Then I started thinking about changes at a distance causing the other >> InitProcessGlobals() tasks to palloc or elog. We could do option-1 in master >> and keep the back branches in their current state. > > I don't feel strongly either way, either. I don't think it's important > enough to diverge from the back-branches. Also, thank you for fixing this. -- nathan