Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIrx1-00HB8V-6N for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Dec 2024 16:10:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tIrwy-0013Vm-NJ for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Dec 2024 16:10:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIrwy-0013VP-D1 for pgsql-hackers@lists.postgresql.org; Wed, 04 Dec 2024 16:10:05 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tIrww-0012NO-Nb for pgsql-hackers@postgresql.org; Wed, 04 Dec 2024 16:10:04 +0000 Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-4668c8e757dso49482331cf.0 for ; Wed, 04 Dec 2024 08:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733328601; x=1733933401; darn=postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=adfzMP2i/b8NOnsMfXfUWFPIOu/9BhJvHC7p+TmIV8U=; b=cA3KMXvSwxZ8jDwogXrAUKKyCW3hKQYNrTT+s+6hGDPcnCpbjTwpQPHKtYZEAdEpJU uJb2Fvjr17e/zY6sRLXZ99Myl9QCQLM9JsvGL7OmzEFEUte2kcRVZpmbQB3LI6wnpELZ rF7208NUtG4GA7KNmO3ePpyeQcgZ8D2r2v3rRwQcn4pcuPf5H/JmDwZ/0X321EncjT9q hc7DrbzfaoagKioVp0xGB+9gqQh6H0h8gEosFsBxQPsX6QtL5kJod3WY725xzlVrvhCG 3N+SXGIr5jlyfjCYjUHI/v/4d0vBVWdryB8S36Z+HkS8T4L3FcsGUnCq7hYQtTRBmnFS a/pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733328601; x=1733933401; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=adfzMP2i/b8NOnsMfXfUWFPIOu/9BhJvHC7p+TmIV8U=; b=mQOu4PcrkhmpH+KjxrvWxjHih3oTQw35zP2ltBEqpXhoL3rkdpYm5j04bg5hjxDBzn EgC6IrZouSxRQIbZkpuCF7DIxFFKaaiK6R8cWR0H+Kh3snLRUiUccmSnJsIVyWpXdI9Y ziIHjhQqyKi38BPMhJw0fxwWKIIF9i2FvkGnpRxR9Dve+3UVlBLWzronzwUKLAehHg5T BIv1RQFgnPxfQO8uNwIqqmMKL8Iwvt2OUmlaT//MYj8i3H8+lHI7K9/d7yjFZjSYWOur 6Puwe0VTQX0wqINUOc0HK8xOaTP/fWsTxCp3otQjRDP3sDFRn5hlkJdTfZfRcl1lmb0K /oaQ== X-Gm-Message-State: AOJu0Yy0Z3LWttnxNAXaMSTRvt7AoX6OYW4Hnw8yOq3veWkFQ1XnJBUa CpUE4DvZDG9HF+T50ms6l8UmrIF5CcQDJ6MrDgbPTeD5Z3cH3jv2k/CTXQ== X-Gm-Gg: ASbGnctK4PgX2aYmJrthx9JPtxGf7//CDm6MSmcDziACCudS4J/dvbbvGrHPSPeOIqq KkRAgUzOv3cpaqOVtJ0+WnfS8E2x+sWuPu4dQ2qFpguQqWM18UfnXlEOAQ4glhRFI1AqdqbtBmp LxWMggqp/X/wIcNM5m0Q8hGv/pAExsuPGGE4p1MfTSiB/NC+z7ssuGMjzrh3Fy5233/Qh5X9Pj5 xcTvBqbj/cQYPWXvaQ4rj4lwnHtQ/2er7y3oCGu+1p4bt6i1++5b0YmFlu9BKSHIgHMM08kF57i 8FzxTsGHrVIKXDcZLrtlu+maulKYdCPjyKB1h4xT X-Google-Smtp-Source: AGHT+IFyMRpPrV2DCFBv6aaZKUqJTkNxmPGoVmrgSEVFbTcAS4Rn+yiMK9DcrgHLycR+mY+CESOv9A== X-Received: by 2002:a05:622a:180d:b0:45f:bca0:b8d2 with SMTP id d75a77b69052e-4670c0959bfmr80034011cf.20.1733328601465; Wed, 04 Dec 2024 08:10:01 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-466c4066442sm75360421cf.20.2024.12.04.08.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2024 08:10:01 -0800 (PST) Date: Wed, 4 Dec 2024 10:09:59 -0600 From: Nathan Bossart To: Robert Haas Cc: "pgsql-hackers@postgresql.org" Subject: Re: checksum verification code breaks backups in v16- Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Dec 04, 2024 at 09:29:50AM -0500, Robert Haas wrote: > On Tue, Dec 3, 2024 at 5:26 PM Nathan Bossart wrote: >> I'm only seeing this code in pg_checksums. Is that what you are proposing >> to change? > > No. This code is present in src/backend/backup/basebackup.c in REL_16_STABLE. D'oh, sorry. Even so, I think I'd still vote for back-patching the v17 commit that inadvertently fixed this. -- nathan