Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 5 Dec 2024 14:34:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Joseph Koshakow <koshy44@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: date_trunc invalid units with infinite value
Message-ID: <Z1E7cTyVbFZJwUWf@paquier.xyz>
References: <CAAvxfHc4084dGzEJR0_pBZkDuqbPGc5wn7gK_M0XR_kRiCdUJQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wkf2lqwQa4TZdQyn"
Content-Disposition: inline
In-Reply-To: <CAAvxfHc4084dGzEJR0_pBZkDuqbPGc5wn7gK_M0XR_kRiCdUJQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z1E7cTyVbFZJwUWf%40paquier.xyz>
Precedence: bulk


--wkf2lqwQa4TZdQyn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Dec 01, 2024 at 03:09:17PM -0500, Joseph Koshakow wrote:
> When looking at the date_trunc function, I noticed that it wasn't
> rejecting invalid units if the value was infinite. It's slightly
> annoying to fix this, but we already do something very similar for
> date_part. I have attached a patch that would fix this issue, let me
> know if you think it's worth pursuing.

I agree that it is inconsistent that we allow infinite values to go
through this function call even for fields that are not listed as
supported by the documentation.  So, yes, I think that what you are
doing the right thing by applying the check based on the units
supported, but I also doubt that it is something that we could
backpatch as it would cause queries to work now to suddenly break.

Thoughts and comments from others are welcome.
--
Michael

--wkf2lqwQa4TZdQyn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdRO3EACgkQnvQgOdby
QH3tFw/+NqkMdsbuKhfjxa2bAMaoYWLhlbk/Dutn+Zz9+vBcJNct9+YV03GwSsh8
FbTtHB8+kNfF2De8iXIjhEXBC4v8M8w8VhK/xs8Y0ZzLdh06To6KozoT0qt0vdBq
RRhZRuu3CWJ1SbKnPY9YV4c/sY1AXRC72GZuTkPFapYOe4q0P2ADRScgZc4jGX/e
xlm2x1tlklZ1a9xlLvll75T+mCYi8T+VQfylr4IC1uxGmpGg3v/qZR7ccsrRHl1u
Aydp73ZehudoTUJvYm5xfJm0vm/qs+PfUZW1q21MuizmLxBQM5gEzkPS9DOgeLAd
/k1XMShP21nuQ6lKJnlZck1Owsz/NDscxtagO2HXuWa48kArAdmZqPO7+sipMNAu
daAQTt9TAaYvup75OMBhaDo5odurOiLLW2gqLtESsdQbrhf+BLySSlwl6D8fKrUY
5FIBx6b9k8x7qxCHXhAeCMM6MNPlo2fa7FALkkW+B/Z21Z84ArsbqgTG+VMXvHu7
6PQetS1T7TPuNtaqmkNp3agn94eJNLyIWFqfx6p2NHNO8RpNrfg/A7x78oI8g+S9
0+BpVTVogAFSVX5tLdZHeOVArG2wk2vNsMjK6lGWTKw23p297HRJzFUEwEUPdZ4l
Ire2JxYVTzZnpLg+isC+KQ5yrX4lNR4IVFuQU0TNmC5CmLGTpQ0=
=Fd0Y
-----END PGP SIGNATURE-----

--wkf2lqwQa4TZdQyn--