Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 10 Dec 2024 16:38:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Michael Banck <mbanck@gmx.net>
Cc: Greg Sabino Mullane <htamfids@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add support for displaying database service in psql
 prompt
Message-ID: <Z1fv8D_t1ok8svgO@paquier.xyz>
References: <6723c612.050a0220.1567f4.b94a@mx.google.com>
 <CAKAnmmKhnHGp4X3FvMAicRsbyiKTWwMJ6oWdkRw2oLVzdeL-0A@mail.gmail.com>
 <6748cfd4.050a0220.1537dc.43bb@mx.google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="p40vq9a5J5QLTc0V"
Content-Disposition: inline
In-Reply-To: <6748cfd4.050a0220.1537dc.43bb@mx.google.com>
Archived-At: <https://www.postgresql.org/message-id/Z1fv8D_t1ok8svgO%40paquier.xyz>
Precedence: bulk


--p40vq9a5J5QLTc0V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 28, 2024 at 09:17:23PM +0100, Michael Banck wrote:
> Hi,
>=20
> On Tue, Nov 19, 2024 at 07:47:58PM -0500, Greg Sabino Mullane wrote:
> > Compiled and tested: works fine, so +1 from me. Honestly, I was surpris=
ed
> > %s was still available. :)
>=20
> Thanks. Was that full review? You kept the commitfest item in "Needs
> Review" state.

No objections to this proposal, that can be useful.  No objections
with the use of 's' for the shortcut in the psql prompt.

Back to your patch, you are missing two things at quick glance:
- Documentation for the new libpq API in 0001.
- Documentation for the new SERVICE and its new %s (see section called
"Prompting" on the psql page.

So please make sure to provide these with the next version of the
patch.
--
Michael

--p40vq9a5J5QLTc0V
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdX7/AACgkQnvQgOdby
QH3yJA//T97AfRfyL0V9UfuCoYnFEVUVnvdIUjCi+pj1qvYTPUxr+ktWS2NyOaop
RqJT5i/b7DMSW9MHq3S+7QOPfMGGixCf31kWPndn3jane9QU7xqB48/GEqT3dAnj
d5QRIDumeOnF7XXb6uQPO4ahrOxCwPQbktJ7+5jhNMg9raJH+NbgACqH918nGanS
IyWxpPmt1qDCBHh5ncv7MT3p7LWfSAvDrQJb7tzB+tpX3SB+whHWLgPxv3ZmzSEw
QZnXIc4yvcVCp3syZzIYGD8dQbnu+aBaG0+YE8QlX1jwcXkWNlG8Vve6ZdgIvkv0
7H9OMLmHL9G/yBtqbHWRGtckKUOVEtu+JKohd/vitJoQ6rwF7WOOHVfbxUFGstPs
yZQLDfmCG9rhcZlwR/sgNKu9pkKzCllS7UYYDA3q7mLtWcRTiyRNRT7EHFdXIiuL
32UtvWpcZMGwSTxT/mkkAJl+mlI5iL01W4E5941lh8m0pM7r5HAt9bYaTWnzuWJ4
+XpYYoNLIWyXEOQZB0duD6pJ4oTe14zs70gieVbRZmuY7bTYxuAey74I+XT9OUip
+oClxUxmLPsHxkWcNQVdIuJ2uV+TNhpsD7CC0tO5P/53AoPr/gTo0LeST7ckvLk1
F7cFNvdDEqTcXh3osmCXPpb56XO4WmNEqpy3zbQVys7l0tOvkME=
=2aId
-----END PGP SIGNATURE-----

--p40vq9a5J5QLTc0V--