Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLEdH-00DYiz-Nv for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Dec 2024 04:47:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tLEdE-00Byn7-H1 for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Dec 2024 04:47:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLEdE-00BymL-6o for pgsql-hackers@lists.postgresql.org; Wed, 11 Dec 2024 04:47:29 +0000 Received: from fout-b4-smtp.messagingengine.com ([202.12.124.147]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLEdC-002CPI-K7 for pgsql-hackers@lists.postgresql.org; Wed, 11 Dec 2024 04:47:28 +0000 Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id B4A531140121; Tue, 10 Dec 2024 23:47:25 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Tue, 10 Dec 2024 23:47:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1733892445; x=1733978845; bh=vNxVSInL3M 2Ri7x6boVzPXyluVK6316zszV3i2zhJeg=; b=jFomgf8eJBWZ3+QC2XDyuCSdYS 61H9HEsvj0cfy2UvwMmdFJ/USc92PxQKSSVgKWaNOLrm3ao5QjSqopn3JvwBCqGh ixphHDkcXQDZA6J/tYTaLdDB4Di8r6Y6+u1ao/WUaR4c+3WyofgmYaSW7FvmUMAC +BG2HL0DtO8uPtWIrF0PB0e443SB/jVZMiqLJbUnP10dXJavQ6JkCO6omCMRn7g6 rfEN/xthL3SyIDxaZL4X847tDH2DUmUjauUdXaG6qAuUWnx2c0VvhIvxBpMEZIhr D0PoxwzChs4YqH0Dvs73Ta1ibiB0TmsObjJSwn0NW8tsuYB3vkW+oiw2aKPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1733892445; x=1733978845; bh=vNxVSInL3M2Ri7x6boVzPXyluVK6316zszV 3i2zhJeg=; b=Fbjr3y/1G9j/D2l/4o5zsuTpBlNRWxoro4QC6DsQxLPKTaJPDHj vdRx7Wxcm80m0y2VLd8QeiNL92hEfD4GtBBL9BCcmbz7RMMH/jX2h7XwDkmOhSSF w3ZTsIT+saiGkM+3/ldA6tjT+Joqb9wnO0/3cM2mtSeyGgP47+6EQ5uxN8lJSBjE TFD5iVoIYQOkZWNwfexOkvlUJR6Wk+n3sGcWII/Nu7MaGl5ToRnhUy4+dQNVahcN /mJG2JKeFAkcQ6DnmLGx5h2mOusfX00vm8rmfWyp5vlugLsfOHQPTHjoIWgoLoM7 IgeCDjtbDfC8bZroJFlUgKiNEp5ZfcvGyng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjeelgdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenfghrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhgg tggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoe hmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleei fedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedvjeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehp rghquhhivghrrdighiiipdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuth dprhgtphhtthhopehtohhmrghssehvohhnughrrgdrmhgvpdhrtghpthhtohepuggrnhhi vghlseihvghsqhhlrdhsvgdprhgtphhtthhopehmsggrnhgtkhesghhmgidrnhgvthdprh gtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhq lhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Dec 2024 23:47:22 -0500 (EST) Date: Wed, 11 Dec 2024 13:47:08 +0900 From: Michael Paquier To: Tomas Vondra Cc: Daniel Gustafsson , Michael Banck , PostgreSQL Hackers Subject: Re: Changing the state of data checksums in a running cluster Message-ID: References: <8B317721-1CB7-4F82-B4DA-6B15AB1725D1@yesql.se> <642b8eeb-06ef-4aed-97a8-5297d9f67142@vondra.me> <2bf72a05-a2ce-4470-ba5a-adff3f087b55@vondra.me> <18750566-7D92-4FFE-9AAE-909AF99D3C33@yesql.se> <817F3431-4A4F-4070-B850-196199CD029F@yesql.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kMRQRPZs7GRWhh+i" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --kMRQRPZs7GRWhh+i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 26, 2024 at 11:07:12PM +0100, Tomas Vondra wrote: > I spent a bit more time doing some testing on the last version of the > patch from [1]. And I ran into this assert in PostmasterStateMachine() > when stopping the cluster: >=20 > /* All types should be included in targetMask or remainMask */ > Assert((remainMask.mask | targetMask.mask) =3D=3D BTYPE_MASK_ALL.mask); >=20 > At first I was puzzled as this happens on every shutdown, but that's > because these checks were introduced by a78af0427015 a week ago. So it's > more a matter of rebasing. Looks like the CI is not really happy about this point.. (Please make sure to refresh the patch status after a review.) -- Michael --kMRQRPZs7GRWhh+i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdZGUwACgkQnvQgOdby QH29DBAAkfPWmggI0yyy/wDQ11JxRJfygGhO++tFrUv1Sju0aDe8Jd8HOsC454tK SW3ySXnokFFU0NA6KsJ2YFsWYuNuWbu2pXkA2ZHPU9m6KNg7xhVVNmbdgeLNg9x2 yhkU8J2EIdaqsY/Bk2PnhmiYH1354GtxDL91C8Kh09gfy0BBEHSFU32xPUn7qHEY YwmrzY4QY1oU5FrvU6Sphn/XSCPP7N2mOSY0IUXBlJ5KMv4Y2w+4sksNLqvyVkWs 4FXtULeBKNH9lSApIPhq7eOutSkjJExIa9KT++xXpeqlrmxDlPfhvP+ZwH9tK/mr lEDH8+PoAtNxl5COq/lVfAFXdadqP/JXymnCLSMXHCdu2w0rI1hCNDq0/vi+j2vI keo2srQJOQayyTMIoLa5C1YsTweS/Pn6z2WkfkrgyHV/n/RPVHEWxwYgIDqivYw8 ABjaVl0wio69bMvITVvnoYsCunt0UHOkZlZPjfqhQYi7o9I6lHVkSoU9jIXRuyLm +Z1pAja0NAA8eKPOtS8F59ei4dNhvdlL6JhHp1v2ORmxDvT5OH4kVPf0r+Qzioag Z5YsUbzWC58srTvIbzYErqqrZLDMdmjcZ3W58cJTAQLR28f2mkS14YVGCQ8FpwU6 Ea7+tfibvgWXldXCE8gvgh0OSa1+g4s1pvcbwwDSMg/Ymo24nv0= =raqy -----END PGP SIGNATURE----- --kMRQRPZs7GRWhh+i--