Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 12 Dec 2024 09:20:15 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Fix comments related to pending statistics
Message-ID: <Z1osP3HsLx7pRokL@paquier.xyz>
References: <Z1hNLvcPgVLPxCoc@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z1kpeNIFHgrE2UAD@paquier.xyz>
 <Z1lAFklwL3TrZfwR@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="l9VyQ8M4Vcft45m+"
Content-Disposition: inline
In-Reply-To: <Z1lAFklwL3TrZfwR@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/Z1osP3HsLx7pRokL%40paquier.xyz>
Precedence: bulk


--l9VyQ8M4Vcft45m+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 11, 2024 at 07:32:38AM +0000, Bertrand Drouvot wrote:
> On Wed, Dec 11, 2024 at 02:56:08PM +0900, Michael Paquier wrote:
>> Your suggestion does not look completely right to me.  There is
>> nothing preventing us from using something else than event counters
>> since we don't use memcpy() and there is no comparison work, no?  It
>> seems to me that we could remove the entire sentence instead.
>=20
> Do you mean also remove the comments in pgstat_function_flush_cb() and
> pgstat_subscription_flush_cb()? Those comments look fine to me given
> the places where those pending entries are created meaning in
> pgstat_init_function_usage() for the functions and pgstat_report_subscrip=
tion_error()
> and pgstat_report_subscription_conflict() for the subscriptions.

My apologies for the confusion.  I see no problem with the existing
comments in pgstat_subscription_flush_cb() and
pgstat_function_flush_cb() because they still apply.  The comment in
pgstat.h=20

The only thing we should do here is to remove the comment for
PgStat_FunctionCounts because we could add pointers or something else
than plain counters in this structure, and fix the comment of
PgStat_TableCounts in the lines of what you are suggesting.
--
Michael

--l9VyQ8M4Vcft45m+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdaLD8ACgkQnvQgOdby
QH1y0xAAqjXcAKEueUKvNyFw9S3T2sex8b/HnXcdMzsx3R3fNqESYlbFrblBFBk7
NUpeW8KhoblQeI/sh9N+dSOnvb+ra4Xp2Cxvqgu/xIZ7/rbVzY+ODTWbq0fvA1sD
OyNmi4+o7YzKie36zvCO+xa7gjMSECrRPxTWriEb0C6J0LQv2TCR8LYnDZapaEDO
7DF1GmQe/pKFIxcmVF9lCaFV0j4M7awTMm9Mfpup2hGpdNNRBTAt/ZHPDFDJQi4w
rQzZI85f/7YCnd6q3b+oIVB718B/qBO5Wn0U9W/dtvrfMFscn+C6BYtvjKcnJFRD
5GOD9abq9DEhTQXeb+VRGiR1J9JG46EQNPHizJJ9Oce9uKpBBnfDy7H93zCIlUXm
Lb6q8+T3xV1FR2rx3MsermB72P0dY2HtsFfWNkYZS44kJIv0xSqWCuR6SzxL9oEW
kfW6Fti0LooqPbSc+8Tb4I9bGIMzz+YI8gmHJoLKu5rOjwbil14mo5sWwsolhuz6
ta0OYbjsHc7Hu3TIy6YAE2Q1H0Lznq3sv51EVLSSb1jyoF2mC3svyI+LnzDTQDzU
PpteXQ5MP0W31HTyJlN9SVw3f54MezV5hCx0sOAqV38cvXR5IrCn382/RuPukThX
UzE08kKajxUMnwvg35TDuusdMWA2XVFBJW4fsbxC6iIIyooTSow=
=q4o1
-----END PGP SIGNATURE-----

--l9VyQ8M4Vcft45m+--