Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 12 Dec 2024 12:53:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard
 to read.
Message-ID: <Z1peKSb8roiDNgRj@paquier.xyz>
References: 
 <CAHut+PvfaUZQR3rEnj-Dcg_6713Wu4yRdd-yZkkC9NVsARht8A@mail.gmail.com>
 <556792.1733967676@sss.pgh.pa.us>
 <CAHut+Ps6Q+i_3xS6H7ybw3-hx9+2QOuneTJwHArxqxFnKX5+4g@mail.gmail.com>
 <564915.1733971586@sss.pgh.pa.us>
 <CAHut+PvFGytgJT+K_e2x+uWKuVYCBR3HNaNtPKYEkO3YxAwZvw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="p4cZmAoHW9x0JiSG"
Content-Disposition: inline
In-Reply-To: 
 <CAHut+PvFGytgJT+K_e2x+uWKuVYCBR3HNaNtPKYEkO3YxAwZvw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z1peKSb8roiDNgRj%40paquier.xyz>
Precedence: bulk


--p4cZmAoHW9x0JiSG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 12, 2024 at 02:13:40PM +1100, Peter Smith wrote:
> TBH, I have no idea what logic perltidy uses. I did find some
> configurations here [1] (are those what it pgperltidy uses?) but those
> claim max line length is 78 which I didn't come anywhere near
> exceeding.

Gave up trying to understand its internals and its rules years ago.
It's complicated enough that we require a specific version of the tool
for the tree with a custom PATH :D

> After some more experimentation, I've noticed that it is trying to
> keep only 2 items on each line. So whether it looks good or not seems
> to depend if there is an even or odd number of options without
> arguments up-front. Maybe those perltidy "tightness" switches?

Don't recall so even under Perl-Tidy-20230309, because it comes down
to the number of elements in these arrays and the length of their
values, not the specific values in each element of the array.

> So, AFAICT I can workaround the perltidy wrapping just by putting all
> the noarg options at the bottom of the command, then all the
> option/optarg pairs (ie 2s) will stay together. I can post another
> patch to do it this way unless you think it is too hacky.

This trick works for me if that makes the long list of option easier
to read.  With two elements of the array perl line, I would just put
some --dry-run or --verbose at the end of their respective arrays.
--
Michael

--p4cZmAoHW9x0JiSG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdaXikACgkQnvQgOdby
QH1w6A//U3QMFer2tLoReyEL4JD9V3o1yMSPdFylmIHIw87CB/mTkibKX8ZmCqqC
ONJJxtB9iop+/Y2FApUbyjwdea44T4Teqd2qO/zIkhbYTDd9mBEltX/LEV9k0xEy
+SZb10ix3AM2n40LiwewSymYrTVduyeH3D0u5YBVUBNDU59/QplJipfIFOiS+5Jh
IQWvWYXnjEPJjE6boodMiOW6yePn72KRFV0cmTb03OqJaD9cy1osv9FuXDREmMpT
sqmIA20nvICXz1PMzMgvWm3K9mftfQYBgJtwx1J2QZ97FDQjO4BgsOvT0Fy/9JW4
B4vpNhTtUGgRzXN2wOODGhQk0S/VTWAAAsmAOr1nCPmMSpIP7zncYxTDn4ULBUpP
0Xkgchzb8lfOAQugGK7T6M9MRMLOzcCfABUftyC+RHU6tcLQCIFG3xFVAi0pWfNG
1h0C6Jz44F9dgxiIWKWZPwU39wF8WUEQIyKTSRt4eiMBSr3Zcbgs6qWN1B3RlJHp
80lSe8//EqdyegwUDixDyaS3ofOaP43jdyMr5I6Hd5LRCdwrf2wdLsedHsdWzUrM
w6jj8uriuaQ+C3MKAfJMB5LRfb1hLIyWoSj6DD3BMeTScoX/GxHdOnPENBDTeeVi
pwwYY/IYy6YK0RIjh0XBSuHM2G2Jftl6DOFMBVtCiy4avYtvUpY=
=tc0v
-----END PGP SIGNATURE-----

--p4cZmAoHW9x0JiSG--