Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 12 Dec 2024 13:11:09 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: per backend I/O statistics
Message-ID: <Z1piXTC8X0uu-MSz@paquier.xyz>
References: <Zz5gMM9w59guO9S_@paquier.xyz>
 <Zz9sno+JJbWqdXhQ@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zz_gHQ2g8MUe8oJ1@paquier.xyz>
 <Z0A3pmORCbhRe0Ug@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z0PNpAjhcS7S-1LI@paquier.xyz>
 <Z0QjeIkwC0HNI16K@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z0Qk3nZcaVpbtCKU@paquier.xyz>
 <Z0ScL5W6EeWXShb3@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z0a9QuH8HRLfT5kY@paquier.xyz>
 <Z0dCDjItim7tp/jB@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QWHBp+DHAuzb4YfO"
Content-Disposition: inline
In-Reply-To: <Z0dCDjItim7tp/jB@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/Z1piXTC8X0uu-MSz%40paquier.xyz>
Precedence: bulk


--QWHBp+DHAuzb4YfO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 27, 2024 at 04:00:14PM +0000, Bertrand Drouvot wrote:
> I'd vote to just keep the pgstat_create_backend_stat() call in pgstat_bei=
nit().
>=20
> That said, we probably should document that init_backend_cb() should not =
call
> pgstat_get_entry_ref(), but that's probably worth another thread.

Hmm, yeah.  I have considered this point and your approach does not
seem that bad to me after thinking much more about it, and you are
putting the call in pgstat_beinit(), which is about initializing the
stats for the backend.  So I'm OK with what the patch does here in
terms of the location where pgstat_create_backend_stat() is called.
--
Michael

--QWHBp+DHAuzb4YfO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdaYl0ACgkQnvQgOdby
QH32MA//Qh204Dn+eh54AsMPlcMKJhy8vGqQolo5t5PjE23pLGZMpn1TBJ3/MZJ3
9Y9/MIeYyy7k4HQzAYQWI5vjs/1azs4efPJIkNNZdRvnHkYmhgg5ASO+YUVYuc/F
bqx0I1GeljNuYz+PPUZgmbSSe1u9mrf3bv2YdF2ox9rWDGfK5kldnEQi+89/8RN4
DTdzEnHn9hdKc94MZgsYSY9iBMAcdjhzdEopntZ1SrD/pq+5+QjR0PFhprp9W+Au
pU8Kgwogg5t3ccDKvgQ2Cxv3GlBH8io9Jj3L7E3Y/UzOaEKRzc3fHQxfPbb4EjUM
4k423ZdTSalAMKsgckbK/Ax7xMS3qzydbqcc4P8x76B8/bZtXwdR8FT+P1rg03DW
aDbYzWR77vBZsRi2tRT9JZBY/EnETJpX3GNoE8pBsPwJlDpKRyT8nwO11U9/zeiJ
oBchSu+KxcSlBmpLpahEUhHkUtsbKtSCsSYw4xUuMPv2Z6xLYYTj+7/dbMrCh6Nl
WGq5ixhyZngpEWNtFAZVuIoNqoIrEXq63BmK5DDSmPVA7dOJ1tagHkmDXcEszaqK
zTqwr+TyLXgey8G7aUQYU+TePgVM466EOK32xYg+ism27x5I/XoxaanMb/ZnWIzy
LfGzSwaB6sL323jMbVEIuuXRgaXbc13JOd0LAQ303aK104eejbE=
=rAev
-----END PGP SIGNATURE-----

--QWHBp+DHAuzb4YfO--