Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLe7z-00G6aE-O0 for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Dec 2024 08:00:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tLe7x-008kbj-9D for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Dec 2024 08:00:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLe7w-008kag-78 for pgsql-hackers@lists.postgresql.org; Thu, 12 Dec 2024 08:00:54 +0000 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLe7t-002QIq-EW for pgsql-hackers@lists.postgresql.org; Thu, 12 Dec 2024 08:00:52 +0000 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id CD57313807BE; Thu, 12 Dec 2024 03:00:47 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Thu, 12 Dec 2024 03:00:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1733990447; x=1734076847; bh=+qjiiofeS5 6yXsWxwy5ub9iMeQYxPAp1GdNYnJN6r/I=; b=drQFSRb9J93pSPRavnBEBsLCwO eUWlnGB8YMH1/tz1lVjT0MnyDxYIPS4uaSEwVVZta/UCeg26mS3T1hB50mkz1sjp wZArAz+tOAvco2MBDKmH0FS8j7L7dqcN9A9DgJd1o0Y5xuYUMAb2+2Tc68Btm/mG 98m4SDXY+Qym9QJrdi6WBulY2lMKBYgdkuzbDimtKx11p2PAdhnKHfphCvkbT5sk N4psxJofRcnVV92+YmllcDQB2LKSGdrWnQZuL8+SFHza2zc3/6MIUZb8Vbh1tA8N XHeCzFvqe3WRBFdLLPHU9B8F7ZeSrIKKUASQUGcX3l8ruyKp4wFloqLY80qQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1733990447; x=1734076847; bh=+qjiiofeS56yXsWxwy5ub9iMeQYxPAp1GdN YnJN6r/I=; b=1/qs6WAUV5NwCi0GLLqnYEvl7ww1MdYc1E7t0ZoAIrQZWG4xGeP xgMUqhpgxoux1OqwpLwfF0zjuZJq2dzkt0s/J8EyMYyCcrpD+qJ7/sBK1UjWB7Xo qur22R4YaPqTELKLY9qly+v6Bav+q7R9/SPvdjtFI3BakMKA35gaNiBdh2GBffdd ho1u8Vj6s/E/zKtyR3hvkU5XMi27a5iqmKZIJIGM6OFd4P4pIO9ahvhbipyDYK1R ebm29B+0YStH4kFYz5DOio/TdVbJt0iFnbA8RVWQmGTiw7fmAHz9LRLNZAK+dzwy dSSgYNAqRGk+WIbIEVXfGy+LtwKPJSnBOfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrkeeggdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtd dmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhi tghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqe enucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeffhfekueevteeigfdu udevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhnsggprhgtphhtthho pedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsvghrthhrrghnuggurhhouh hvohhtrdhpghesghhmrghilhdrtghomhdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgv rhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Dec 2024 03:00:46 -0500 (EST) Date: Thu, 12 Dec 2024 17:00:34 +0900 From: Michael Paquier To: Bertrand Drouvot Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Fix comments related to pending statistics Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v8cWc8VWiCrbvRpH" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --v8cWc8VWiCrbvRpH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 12, 2024 at 05:07:23AM +0000, Bertrand Drouvot wrote: > Yeap. I also just realized that the same kind of comments are missing for > PgStat_BgWriterStats and PgStat_CheckpointerStats (for which we make use > of pg_memory_is_all_zeros() to detect whether there are any stats updates to > apply). Adding those in passing. Good point. I've slightly tweaked a few things for consistency and the result looked OK, so applied. -- Michael --v8cWc8VWiCrbvRpH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdamCIACgkQnvQgOdby QH37QQ/9EWYjUum1Kk735P2ldVi78uq6kGLxBz5eXFX7vDFfHs1vgum2xIldijL0 0LX7Uw3Nwk89da/DxipJ36sKB7djdXG7F84T01RdG3XoYPel9SAnMUiLV1csG98B HxL57z7679iFbT1FKvDuQB41Ob6r0uXdLfSBMkywTyDxijy67aapx84U3wo5ilAB VM4Bqd7JviN4o3G2Wx2exn+X0iRGUhslThiylr8dWU4RcaxFQT37Kb/UoMHWT+0/ qQ6SCZeh/59ruo31tA6R+U2pOKa3Y04svDU7zHKsiaVdw5Y3cP3fPpUsi7myfrs6 s9ZqtczJtYQOaNvY0RPrkKJRy23pTekfS/YfsjPvawB2kAJTUnN6iCPVxNrwMzV/ AktTJVBOLLJ3IaPGOFnm8JeXQYwAGv9/tGSoJIQatCIAeUCXBzEQ90oTAhXAo94/ i+Yoc6sO7zg0BrolvbwYQH8CUULTMhX6NrJjz8+vzTe4muvwN2x2ahmV7ZjUp5+j v1E7Kb9qpQxSAulh0aJuu22XElWWdbTj3OB4xtDVCCDO56iySE2OjT7wwZVZCmX3 dfQcIm+GL1/gPnNiNeJk3qfS0uHOxOGErg0sRIdEoFQBf+GeIlZp5OzuVuS3xmQZ nPdCQ2FZ6RlipuqvxkBBhlPPXoUDx2vUw2mitLis8GcNUD+Mkj4= =5FY0 -----END PGP SIGNATURE----- --v8cWc8VWiCrbvRpH--