Date: Mon, 16 Dec 2024 16:18:26 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andreas 'ads' Scherbaum <ads@pgug.de>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Crash: invalid DSA memory alloc request
Message-ID: <Z2CnMpS2srwNxfXg@nathan>
References: <80a12d59-0d5e-4c54-866c-e69cd6536471@pgug.de>
 <CAEze2WhO235HKnc=qCh7GmjXBpL9LDPC6qQk4pvq57cZiDC7Pg@mail.gmail.com>
 <CAMDzVO820R2ASuZt7jE3K2+hOARwGAodPxzxjFDq2mgZNoBmSg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMDzVO820R2ASuZt7jE3K2+hOARwGAodPxzxjFDq2mgZNoBmSg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z2CnMpS2srwNxfXg%40nathan>
Precedence: bulk

On Mon, Dec 16, 2024 at 08:00:00AM +0100, Andreas 'ads' Scherbaum wrote:
> Can confirm that the crash no longer happens when applying your patch.

The patch looks reasonable to me.  I'll commit it soon unless someone
objects.  I was surprised to learn that the DSA_ALLOC_HUGE flag is only
intended to catch faulty allocation requests [0].

> Was able to both continue the old and crashed test, as well as run a new
> test:
> 
> tabletest=# select count(*) from information_schema.tables;
>   count
> ----------
>  20000211
> (1 row)

That's a lot of tables...

[0] https://postgr.es/m/28062.1487456862%40sss.pgh.pa.us

-- 
nathan