Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 17 Dec 2024 16:43:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Michael Banck <mbanck@gmx.net>
Cc: Greg Sabino Mullane <htamfids@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add support for displaying database service in psql
 prompt
Message-ID: <Z2ErmZD1lImYt_as@paquier.xyz>
References: <6723c612.050a0220.1567f4.b94a@mx.google.com>
 <CAKAnmmKhnHGp4X3FvMAicRsbyiKTWwMJ6oWdkRw2oLVzdeL-0A@mail.gmail.com>
 <6748cfd4.050a0220.1537dc.43bb@mx.google.com>
 <Z1fv8D_t1ok8svgO@paquier.xyz>
 <6760a25e.a70a0220.2e9d8f.d542@mx.google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="6trddDg5Zwe8vfKu"
Content-Disposition: inline
In-Reply-To: <6760a25e.a70a0220.2e9d8f.d542@mx.google.com>
Archived-At: <https://www.postgresql.org/message-id/Z2ErmZD1lImYt_as%40paquier.xyz>
Precedence: bulk


--6trddDg5Zwe8vfKu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 16, 2024 at 10:57:49PM +0100, Michael Banck wrote:
> Thanks, I have added the documentation now in v2.

The doc additions seem fine to me.  I've just grabbed three tiny nits,
nothing critical.

+				case 's':
+					if (PQservice(pset.db))
+						strlcpy(buf, PQservice(pset.db), sizeof(buf));
+					break;

Other code paths of get_prompt check for pset.db being NULL.  True
that it does not matter when calling PQservice() with a connection
that does not exist.  For consistency with the surroundings this
should be done at least?

+        <para>
+        The service from <filename>pg_service.conf</filename>, if applicab=
le.
+        </para>

pg_service.conf is not especially true as it depends on the
environment used.  For psql, perhaps just use "The service name, if
applicable".  No need to be fancy.

--- a/src/interfaces/libpq/exports.txt
+++ b/src/interfaces/libpq/exports.txt
@@ -205,3 +205,4 @@ PQcancelFinish            202
[...]
+PQservice                 206

You didn't miss that, nice.
=20
+      <varlistentry id=3D"app-psql-prompting-s">
+        <term><literal>%s</literal></term>
+        <listitem><para>The name of the service entry, if any.</para></lis=
titem>
+      </varlistentry>

Other entries don't use "if any", would just cut it.
--
Michael

--6trddDg5Zwe8vfKu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdhK5kACgkQnvQgOdby
QH0/ZQ/+IC8lIPhmbXTbWBgkP0gCb4cqcMfsYbpGorIQS5kfgB2kg6pmy34DeaX5
of1bnnh7ntXNj9neardWQvZrfzuNUNfqsHkJn7BoLfFq7/akXpz3Fkg9FOB1jjsr
CBkGWqwfcmZl39U9xyPhQr3S07i7nDNOeyI4ETartlbhM1MYYIafn1ghxt+L49Cb
0uT2G8ztxXaIsVZWKDA7hiQQkEknCOM36OgBw9FuvmVhpFQ1WNP2XeDWSURZhiwe
//n2o8kGHXcy8L8Rjpwm58sDFI+R6VFLBhkiF7mH2YMuEfDZx3zvr5Eues3TRtU6
O4EWaU7G6AoSabfoU9kCuUD7J7Fs44e07lDaIBKazLdN6NdE125cMr83diVuvuOs
yozfVOqgvGD2skwxt7UJ6kH0jm9haiJenSJEdVyC4FQC7dBw9H3g5PQaHVMl7vec
dSYZfH5LierTqa3xsdFSnAxmidVLToQFz1j01//U3HxlsNmqgHNBzqLMxW23/Rxc
IyHZbIRIOPBECP+XRdETEKTH4lSXcoqwB8tv+Dte9doseJj7OjrFlfv1zDXwZJhL
nMGa/34oEO/RrA9erqIT1BQdMWiptRVLF7IXJ02XB1Jur81PFJnZkzn0t/1YXqVo
qpXIY/p4olgFfHk1fDp72MZYlrrVkbCguBcVdtebBRcaxc0YbRM=
=ptBl
-----END PGP SIGNATURE-----

--6trddDg5Zwe8vfKu--