Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 17 Dec 2024 16:50:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andreas 'ads' Scherbaum <ads@pgug.de>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Crash: invalid DSA memory alloc request
Message-ID: <Z2EtVQOJHs5Ld7G1@paquier.xyz>
References: <80a12d59-0d5e-4c54-866c-e69cd6536471@pgug.de>
 <CAEze2WhO235HKnc=qCh7GmjXBpL9LDPC6qQk4pvq57cZiDC7Pg@mail.gmail.com>
 <CAMDzVO820R2ASuZt7jE3K2+hOARwGAodPxzxjFDq2mgZNoBmSg@mail.gmail.com>
 <Z2CnMpS2srwNxfXg@nathan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="N2yG2V//StO6r2fa"
Content-Disposition: inline
In-Reply-To: <Z2CnMpS2srwNxfXg@nathan>
Archived-At: <https://www.postgresql.org/message-id/Z2EtVQOJHs5Ld7G1%40paquier.xyz>
Precedence: bulk


--N2yG2V//StO6r2fa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 16, 2024 at 04:18:26PM -0600, Nathan Bossart wrote:
> On Mon, Dec 16, 2024 at 08:00:00AM +0100, Andreas 'ads' Scherbaum wrote:
>> Can confirm that the crash no longer happens when applying your patch.
>=20
> The patch looks reasonable to me.  I'll commit it soon unless someone
> objects.  I was surprised to learn that the DSA_ALLOC_HUGE flag is only
> intended to catch faulty allocation requests [0].

No objections.

Most likely this issue gets by a large degree easier to reach now that
we can plug into the backend custom pgstats kinds.  If pgstats or an
equivalent implementation uses pgstats, I don't think that we'll be
able to live without lifting this limit (500k query entries are
common, at 2kB each it would be enough to blow things), so using
DSA_ALLOC_HUGE sounds good to me.  I don't see a huge point in
backpatching, FWIW.

>>  20000211
>=20
> That's a lot of tables...
>=20
> [0] https://postgr.es/m/28062.1487456862%40sss.pgh.pa.us

And most likely don't do that.  If you want to play more in this area,
there is also the join-1M-tables-in-a-single-query game.
--
Michael

--N2yG2V//StO6r2fa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdhLVUACgkQnvQgOdby
QH3pbhAAp0FlLVRad3iWN0P7PEUKwBUo4I2gCtW6V3PZURlR3gE0EzO1F5ZfAqts
aUESbrV6kTNvNL9D6mnm8Ue2wGopsEz+gYCb+eTBOLDjJUDKKBPobiXyJw1hLa4r
+8UkICWwfGw6vwj8N9wgBm58J3KsiCsd7yDEdWUe4qipmPObQDNaFiDTBMVGV5ML
Slb8nUEMyNufGv8o0i7V9gV9qP7PA6E1jwwq7rt0bt9w+HuxcKWhsvlo6Vz5YHzW
qJZwRJbe402kFYSxdlINIScpDYdl+5/aF1JTVilXgwbJju9c6UCsCJUEwK3NQc3b
IcS0rg/mS3Am9SoXket0cluH+lAeBoQcYC91xE2awNokuRNpNnN7jAvz83nN4XdJ
/exIZW4x6wNehpoN8fz9MTqaBTPRb7/6P4TXTlDlby0zhvVEhtYdxmyA9Yzw2JKE
C59Rly3UbgnBddXa+eiwl4B2piIj2hQiHJml6Fg+Dp+g0Xr4mcgiC6vZZk+C7K2H
FtdHw/rZ8BuRiluboz49IrwG3gWjiXSHr69wGu647xEys7AXKjj9LkS7pH4Caaui
uansmHO4wkLxZ3RDM6AorKWE3jfnsDgduDRPORWg9Z0jyt+sGa0nzZmr4zVd0j7x
cJdHM02ZrD3efQWxYKTEhchyWu24/oU5vgNAXeQ0GZkduDikSj0=
=wcii
-----END PGP SIGNATURE-----

--N2yG2V//StO6r2fa--