Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tNTed-00BJQU-Pd for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Dec 2024 09:14:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tNTeb-00GndR-4X for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Dec 2024 09:14:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tNTeZ-00GnYF-WD for pgsql-hackers@lists.postgresql.org; Tue, 17 Dec 2024 09:14:10 +0000 Received: from fhigh-b1-smtp.messagingengine.com ([202.12.124.152]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tNTeY-003GPN-6i for pgsql-hackers@lists.postgresql.org; Tue, 17 Dec 2024 09:14:07 +0000 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id ABF6725401AD; Tue, 17 Dec 2024 04:14:04 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 17 Dec 2024 04:14:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1734426844; x=1734513244; bh=YKPrFsTFW3 +gbbN21u0ldkbZhiJsiPeexfnyFG+562o=; b=Xj8oZWfg2wHnygyEJ3u3CpiHpG EyIlOF2+jkjpu5ZmHrtv9B4dqp3ftP61CqpJeUsVqvqp/Yxx2nhUCeSUM7GuOZ+B cWZaxPLL0cuTdS1owAgbVPE+L2f1RKqPAZGplWIjSx9awScvxUBU6KTigDYFui/m 2q2KdgP75RUnv8/lRUFS2ogq9uMWGuRAeuhPoHIKQdxVNNrV9car8bkYT0TbLwp4 oecWtYz81D59oVCrkY56EdLS4ctzafbiQDQDnGvgb3SIHZB5feFvOzr0/YflqGSe /DMl9b7spPGseONlSMzeUrfuhmMggAooh5NepL/b/e1r7KvXZk3ahB5j7vkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1734426844; x=1734513244; bh=YKPrFsTFW3+gbbN21u0ldkbZhiJsiPeexfn yFG+562o=; b=L4UiXhpUIafSwu59ebZcIjQmvkUqYO79H7OPMTLe5Hi71ONFvNO dvbyadl0FK0aRT4+rL3cEXkV3iKhqcUVBbi7vNIJOCT4bC9DV1/mDr+4bMvUAWBa HR5ZA0jA94tnMC1Rpn1SsjtT7oK7vrwHPoYa0wiDRnNL6364u7NK2LENQanhaC5C qaT4bzXplBA2pmSx/ZAK3FDMHi1gkxCXoNJJXauZPrCqokoy4GXJdmCkGs/hUam4 iCS8Rj6qUYB57IdoR/5jMeagqpnvTNJzlRO/xQJvOzhQrJY3B8v8pvvUIo2aBD68 vARqw6iEYJVKxZzUl+CI0wZsOfOgK+sqY0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrleehgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenfghrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhgg tggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoe hmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleei fedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedvjeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehp rghquhhivghrrdighiiipdhnsggprhgtphhtthhopeehpdhmohguvgepshhmthhpohhuth dprhgtphhtthhopegsvghrthhrrghnuggurhhouhhvohhtrdhpghesghhmrghilhdrtgho mhdprhgtphhtthhopegshigrvhhuiiekudesghhmrghilhdrtghomhdprhgtphhtthhope grlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgpdhrtghpthhtohephhhorhhi khihohhtrgdrnhhtthesghhmrghilhdrtghomhdprhgtphhtthhopehpghhsqhhlqdhhrg gtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Dec 2024 04:14:02 -0500 (EST) Date: Tue, 17 Dec 2024 18:13:44 +0900 From: Michael Paquier To: Bertrand Drouvot Cc: Nazir Bilal Yavuz , Alvaro Herrera , Kyotaro Horiguchi , pgsql-hackers@lists.postgresql.org Subject: Re: per backend I/O statistics Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l4fDoGXwbxquxsFH" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --l4fDoGXwbxquxsFH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 17, 2024 at 08:13:59AM +0000, Bertrand Drouvot wrote: > Having said that, v9-0002 looks good to me (except the pgstat_fetch_proc_stat_io > renaming). This routine returns a PgStat_Backend from a pgstats entry of type PGSTAT_KIND_BACKEND, so the name in v9-0001 would not be true once more types of stats data are attached to this structure. The name in v9-0002 is more consistent long-term. -- Michael --l4fDoGXwbxquxsFH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdhQMgACgkQnvQgOdby QH3jSQ/+IeO27X6pTspVZVThVe8BFwnlOvVXOWs5FCdJskbuqda020NqLC04oneh h13CDNKgQDWhko5YTPyulc8vwVvzfV5KwToXCEfx/q1MxzNAbM8pDFzMKcXVMg/c kVXG/9v5UcJZzQCuQ8uKVE+kG66fs5QcjXFzcG1gRCNuZtk7azfJ0t3wZdEGnfCy hMWkppSXSaSd0iKyNjr6lPNgjSN6Djr0/GFccj5UwuQyWvCeGZwhqKM64R2fr07z 8K8SYcQdUv56gb/gpGArvyYqm2BMgPs16UtFxhWGiDY+PvB/GAyiVg+yygGmymJk DDeFdz70Ne+5WSq6nmDbRebH96u+OA8g2b5QpRHPrET6/INQf2L1dA244Z+4B8SI MBtPis96YLzyLQDK3c9MefASF8st1HCzfoEjbry15pB+XreI9vIdUGKqXC0gWrB4 gqNqRo6LEFGZO0Buqaf5Mx0FuII5S8b30dvHe/yE+3c39pcSBbDiX5cODK8/lG/S zwxZBFFXI/ftDSayFgAQ3ipwFWa+ceqmtSOa78ZM8WVTJITHYUdPfc0qmktkRkQ8 VJ4jLf6Nv0nTP5hji2bSvLjlGtL7NBsfM8Ay8bjfmFZR86/RGN1PP7dZcpqd7BXH 2tZrIGRNkTKe+qtNPaaF8BueepQ7azD6DR08PjdRC8nFdGw4qEY= =TpRH -----END PGP SIGNATURE----- --l4fDoGXwbxquxsFH--