Date: Tue, 17 Dec 2024 09:35:37 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: per backend I/O statistics
Message-ID: <Z2FF6ScWef9yIrJL@ip-10-97-1-34.eu-west-3.compute.internal>
References: <Z0ScL5W6EeWXShb3@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z1pr86DCR_P6iTSV@paquier.xyz>
 <Z1rs/j5JMdTbUIJJ@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z1uVzXFE9WhSicOx@paquier.xyz>
 <Z1v8TQbeTyHH5kxU@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z1_f2FzvUoL9KZsQ@paquier.xyz>
 <Z2BKTK9KX5Kc3HaU@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z2EZegYbH22LQHhN@paquier.xyz>
 <Z2EyxyEJPMMldj1t@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z2FAyFSg-lRGFZio@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z2FAyFSg-lRGFZio@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Z2FF6ScWef9yIrJL%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Tue, Dec 17, 2024 at 06:13:44PM +0900, Michael Paquier wrote:
> On Tue, Dec 17, 2024 at 08:13:59AM +0000, Bertrand Drouvot wrote:
> > Having said that, v9-0002 looks good to me (except the pgstat_fetch_proc_stat_io
> > renaming).
> 
> This routine returns a PgStat_Backend from a pgstats entry of type
> PGSTAT_KIND_BACKEND, so the name in v9-0001 would not be true once
> more types of stats data are attached to this structure.

Fair enough, let's go with the name change done in v9-0002.

> The name in
> v9-0002 is more consistent long-term.

Agree, we may need to add parameters to it but we'll see when the time comes.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com