Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 19 Dec 2024 13:21:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: per backend I/O statistics
Message-ID: <Z2OfYh3QJ7M5D0i-@paquier.xyz>
References: <Z1uVzXFE9WhSicOx@paquier.xyz>
 <Z1v8TQbeTyHH5kxU@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z1_f2FzvUoL9KZsQ@paquier.xyz>
 <Z2BKTK9KX5Kc3HaU@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z2EZegYbH22LQHhN@paquier.xyz>
 <Z2EyxyEJPMMldj1t@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z2FAyFSg-lRGFZio@paquier.xyz>
 <Z2FF6ScWef9yIrJL@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z2JWUaY8AHBs99yp@paquier.xyz>
 <Z2KDy56Ls4nBl1Y8@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+l93GRLXykYDL2tJ"
Content-Disposition: inline
In-Reply-To: <Z2KDy56Ls4nBl1Y8@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/Z2OfYh3QJ7M5D0i-%40paquier.xyz>
Precedence: bulk


--+l93GRLXykYDL2tJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 18, 2024 at 08:11:55AM +0000, Bertrand Drouvot wrote:
> I think I prefer pg_stat_io_build_tuples() and used that name in v11
> attached.

I'll rely to your naming sense than mine, then :D

> I think that this comment is now confusing since the extra loop would be
> done in pg_stat_io_build_tuples() and not where the comment is written. O=
ne
> option could have been to move the assert and the comment in pg_stat_io_b=
uild_tuples()
> but I think it's better to have the assert before the pgstat_tracks_io_bk=
type()
> call in pg_stat_get_io(), so modified the comment a bit instead.
>=20
> 0002 is the per-backend stats I/O with yours tweaks.

While doing more tests with backends exiting concurrently with their
stats scanned, I have detected one path in pg_stat_get_backend_io()
after calling pgstat_get_beentry_by_proc_number() where we should also
check that it does not return NULL, or we would crash on a pointer
dereference when reading the backend type.

Fixed that, bumped the two version counters, and done.
--
Michael

--+l93GRLXykYDL2tJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdjn2IACgkQnvQgOdby
QH0f4xAAqZb1kVaWXqS1vjqu0R9oTiOGIemS2YbOSY7Rr7ukyf70StRoNZBn4kwi
8FHdNUOvTyYnUYimDzGpgP73WQQwahgRY3oan1oSsv3BWZRJ7OWrYwoYRvR6JVAD
xXWQVMxo1+HvHdGnBNO02Ol+BGA2tzs+7/v2Jtq8Z0ZAsye+ycakvPJ2eRIXN88R
Kev6xl/OfVUgfZ5ZTgBubXXDtHpaMdnoHP3zsvtg2B5n/Il8uUA6w/3G+btR3JIR
UAOYTw454XUvLCP7j5cLAGP8nJFAvyYDCKAkjQqMdlL5WxKG7Zf+tvC0t64Pz8eo
dQPclt/ueqNY9+ICA14PWgvYFmMsSpoqsw/h+NDO+bA6v0FL3w0mD2nsCsyckDLi
8VkL7eh8e7jm9KWS1zAAggXOvnpU8cdzm8fqxd+Nw8F/VfA5AmoKa4PIVE98uFsd
MRY5YIn6CkcbF8tDwiVJfNgIjrGrv2Lv4bd68YP2MwFfkfElLeUfunNaeuMKeerV
vmsTh1wnVcYi3KSdohk9Lx2XZGWuNFFSN59A+/wSI7pj6I/GUWBqk3aZOPWCWKOG
pOHpKzdwZC8ysBICexyK004Oy/mUbrakf/4PH6oyjp7xl61kOKJ6uwBe2m+DxjEC
cHEva/lvOoRCmKiAuICVmxeDr7zgpx7eTYkSJQ8qe50ITkuflfQ=
=dFrn
-----END PGP SIGNATURE-----

--+l93GRLXykYDL2tJ--